Skip to content

Log FederatorAlreadySignedException as info, not error - #621

Merged
marcos-iov merged 1 commit into
masterfrom
exception-logging
Jul 8, 2026
Merged

Log FederatorAlreadySignedException as info, not error#621
marcos-iov merged 1 commit into
masterfrom
exception-logging

Log FederatorAlreadySignedException as info, not error

4cd18bf
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jul 8, 2026 in 38s

Quality Gate passed

Issues
94 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.9% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 220 in src/test/java/co/rsk/federate/btcreleaseclient/BtcReleaseClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD9CXTRWAAPg0EcT3&open=AZ9DD9CXTRWAAPg0EcT3&pullRequest=621

Check warning on line 253 in src/test/java/co/rsk/federate/signing/hsm/client/HSMSigningClientV1Test.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD9AITRWAAPg0EcTd&open=AZ9DD9AITRWAAPg0EcTd&pullRequest=621

Check warning on line 119 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD89bTRWAAPg0EcS9&open=AZ9DD89bTRWAAPg0EcS9&pullRequest=621

Check warning on line 121 in src/main/java/co/rsk/federate/FederatorSupport.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Disambiguate this call by either casting as "Object" or "Object[]". 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD8-qTRWAAPg0EcTJ&open=AZ9DD8-qTRWAAPg0EcTJ&pullRequest=621

Check warning on line 96 in src/test/java/co/rsk/federate/signing/hsm/client/PowHSMSigningClientRskMstTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD9A9TRWAAPg0EcTm&open=AZ9DD9A9TRWAAPg0EcTm&pullRequest=621

Check warning on line 696 in src/main/java/co/rsk/federate/BtcToRskClient.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Specify a "Federation" parameter instead. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD8_ITRWAAPg0EcTR&open=AZ9DD8_ITRWAAPg0EcTR&pullRequest=621

Check warning on line 186 in src/test/java/co/rsk/federate/signing/hsm/client/PowHSMSigningClientBtcTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD8_wTRWAAPg0EcTV&open=AZ9DD8_wTRWAAPg0EcTV&pullRequest=621

Check warning on line 420 in src/test/java/co/rsk/federate/btcreleaseclient/BtcReleaseClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "serializedOutpointValues" which hides the field declared at line 339. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD9CXTRWAAPg0EcT8&open=AZ9DD9CXTRWAAPg0EcT8&pullRequest=621

Check warning on line 3379 in src/test/java/co/rsk/federate/BtcToRskClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "activeFederation" which hides the field declared at line 61. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD9DLTRWAAPg0EcUE&open=AZ9DD9DLTRWAAPg0EcUE&pullRequest=621

Check warning on line 166 in src/main/java/co/rsk/federate/signing/ECDSAHSMSigner.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Simplify the code by replacing .stream().forEach() with .forEach(). 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD88yTRWAAPg0EcS0&open=AZ9DD88yTRWAAPg0EcS0&pullRequest=621

Check warning on line 261 in src/test/java/co/rsk/federate/btcreleaseclient/BtcReleaseClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD9CXTRWAAPg0EcT4&open=AZ9DD9CXTRWAAPg0EcT4&pullRequest=621

Check warning on line 204 in src/test/java/co/rsk/federate/signing/hsm/client/PowHSMSigningClientBtcTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD8_wTRWAAPg0EcTW&open=AZ9DD8_wTRWAAPg0EcTW&pullRequest=621

Check warning on line 4070 in src/test/java/co/rsk/federate/BtcToRskClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "federatorSupport" which hides the field declared at line 66. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD9DMTRWAAPg0EcUJ&open=AZ9DD9DMTRWAAPg0EcUJ&pullRequest=621

Check warning on line 176 in src/test/java/co/rsk/federate/btcreleaseclient/BtcReleaseClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "times". 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD9CXTRWAAPg0EcT0&open=AZ9DD9CXTRWAAPg0EcT0&pullRequest=621

Check warning on line 164 in src/test/java/co/rsk/federate/signing/ECDSAHSMSignerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD9BoTRWAAPg0EcTt&open=AZ9DD9BoTRWAAPg0EcTt&pullRequest=621

Check warning on line 131 in src/test/java/co/rsk/federate/signing/hsm/client/HSMSigningClientV1Test.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD9AITRWAAPg0EcTZ&open=AZ9DD9AITRWAAPg0EcTZ&pullRequest=621

Check warning on line 248 in src/test/java/co/rsk/federate/signing/ECDSAHSMSignerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD9BoTRWAAPg0EcTx&open=AZ9DD9BoTRWAAPg0EcTx&pullRequest=621

Check warning on line 224 in src/test/java/co/rsk/federate/signing/hsm/client/PowHSMSigningClientBtcTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD8_wTRWAAPg0EcTX&open=AZ9DD8_wTRWAAPg0EcTX&pullRequest=621

Check warning on line 123 in src/test/java/co/rsk/federate/signing/ECDSASignerFactoryTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD9B_TRWAAPg0EcTy&open=AZ9DD9B_TRWAAPg0EcTy&pullRequest=621

Check warning on line 15 in src/main/java/co/rsk/federate/config/PowpegNodeSystemProperties.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "REGTEST" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD891TRWAAPg0EcTG&open=AZ9DD891TRWAAPg0EcTG&pullRequest=621

Check warning on line 236 in src/test/java/co/rsk/federate/signing/hsm/client/HSMSigningClientV1Test.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD9AITRWAAPg0EcTc&open=AZ9DD9AITRWAAPg0EcTc&pullRequest=621

Check warning on line 569 in src/main/java/co/rsk/federate/BtcToRskClient.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD8_ITRWAAPg0EcTK&open=AZ9DD8_ITRWAAPg0EcTK&pullRequest=621

Check warning on line 4139 in src/test/java/co/rsk/federate/BtcToRskClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "federatorSupport" which hides the field declared at line 66. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD9DMTRWAAPg0EcUL&open=AZ9DD9DMTRWAAPg0EcUL&pullRequest=621

Check warning on line 150 in src/test/java/co/rsk/federate/signing/hsm/client/PowHSMSigningClientBtcTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD8_wTRWAAPg0EcTT&open=AZ9DD8_wTRWAAPg0EcTT&pullRequest=621

Check warning on line 37 in src/test/java/co/rsk/federate/signing/hsm/client/HSMResponseHandlerBaseTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove redundant visibility modifiers from this test class and its methods. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ9DD9AbTRWAAPg0EcTg&open=AZ9DD9AbTRWAAPg0EcTg&pullRequest=621
View more details on SonarQubeCloud