Repository navigation
Log FederatorAlreadySignedException as info, not error - #621
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
julia-zack
approved these changes
Jul 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines exception handling in BtcReleaseClient.tryGetReleaseInformation to better reflect expected/benign conditions in logs: when a pegout is already signed by the current federator, it is now logged at info instead of error.
Changes:
- Split the previous multi-exception catch into a dedicated
FederatorAlreadySignedExceptioncatch withinfologging. - Keep
FederationCantSignExceptionandHSMReleaseCreationInformationExceptionlogged aserrorwith context.
Comment on lines
+381
to
+383
| } catch (FederatorAlreadySignedException e) { | ||
| logger.info("[tryGetReleaseInformation] {}", e.getMessage()); | ||
| } catch (FederationCantSignException | HSMReleaseCreationInformationException e) { |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the exception handling logic in the
tryGetReleaseInformationmethod inBtcReleaseClient.javato provide more specific logging for different exception types. The main change is splitting the catch block to handleFederatorAlreadySignedExceptionseparately with an info log, while other exceptions are still logged as errors.Exception handling improvements:
src/main/java/co/rsk/federate/btcreleaseclient/BtcReleaseClient.java: Now catchesFederatorAlreadySignedExceptionseparately and logs it as an info message, whileFederationCantSignExceptionandHSMReleaseCreationInformationExceptionare logged as errors with additional context.