Skip to content

[jazzy] Add validation for empty file path in compression process (backport #2398)#2411

Open
mergify[bot] wants to merge 1 commit intojazzyfrom
mergify/bp/jazzy/pr-2398
Open

[jazzy] Add validation for empty file path in compression process (backport #2398)#2411
mergify[bot] wants to merge 1 commit intojazzyfrom
mergify/bp/jazzy/pr-2398

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented Apr 23, 2026

Description

This PR adds extra validation for an empty file path in the SequentialCompressionWriter::compress_file(compressor, file_relative_to_bag).

Is this user-facing behavior change?

Did you use Generative AI?

No.

Additional Information

Can be backported


This is an automatic backport of pull request #2398 done by [Mergify](https://mergify.com).

Signed-off-by: Michael Orlov <morlovmr@gmail.com>
(cherry picked from commit b7370e4)
@MichaelOrlov MichaelOrlov changed the title Add validation for empty file path in compression process (backport #2398) [jazzy] Add validation for empty file path in compression process (backport #2398) Apr 23, 2026
Copy link
Copy Markdown
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI.

@MichaelOrlov
Copy link
Copy Markdown
Contributor

MichaelOrlov commented Apr 23, 2026

Pulls: #2411
Gist: https://gist.githubusercontent.com/MichaelOrlov/fae77a6972100f26fed57d81aa108721/raw/e4d362b02bca274f04ba885a4502004841fa82fe/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_compression
TEST args: --packages-above rosbag2_compression
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19057

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant