Skip to content

Add validation for empty file path in compression process#2398

Merged
MichaelOrlov merged 1 commit intorollingfrom
morlov/check_for_empty_filename_in_compressor
Apr 14, 2026
Merged

Add validation for empty file path in compression process#2398
MichaelOrlov merged 1 commit intorollingfrom
morlov/check_for_empty_filename_in_compressor

Conversation

@MichaelOrlov
Copy link
Copy Markdown
Contributor

Description

This PR adds extra validation for an empty file path in the SequentialCompressionWriter::compress_file(compressor, file_relative_to_bag).

Is this user-facing behavior change?

Did you use Generative AI?

No.

Additional Information

Can be backported

Signed-off-by: Michael Orlov <morlovmr@gmail.com>
@MichaelOrlov MichaelOrlov marked this pull request as ready for review April 14, 2026 04:45
Copy link
Copy Markdown
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI.

@MichaelOrlov
Copy link
Copy Markdown
Contributor Author

Pulls: #2398
Gist: https://gist.githubusercontent.com/MichaelOrlov/5fe41f008dae722a4bd93eb15b14ff07/raw/8061bc7eb4f42036fa45e628092c2fef21c0baee/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_compression
TEST args: --packages-above rosbag2_compression
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18956

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@MichaelOrlov
Copy link
Copy Markdown
Contributor Author

  • Linux-rhel Build Status

@MichaelOrlov MichaelOrlov merged commit b7370e4 into rolling Apr 14, 2026
13 checks passed
@MichaelOrlov MichaelOrlov deleted the morlov/check_for_empty_filename_in_compressor branch April 14, 2026 22:38
MichaelOrlov added a commit that referenced this pull request Apr 14, 2026
Signed-off-by: Michael Orlov <morlovmr@gmail.com>
@MichaelOrlov
Copy link
Copy Markdown
Contributor Author

https://github.com/Mergifyio backport kilted

@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 14, 2026

backport kilted

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Apr 14, 2026
Signed-off-by: Michael Orlov <morlovmr@gmail.com>
(cherry picked from commit b7370e4)
sloretz added a commit that referenced this pull request Apr 15, 2026
* 0.33.1 (Generated changelogs using Gemini)

Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>

* Update changelogs after rebasing on top of #2398 and #2395

Signed-off-by: Michael Orlov <morlovmr@gmail.com>

---------

Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Michael Orlov <morlovmr@gmail.com>
Co-authored-by: Michael Orlov <morlovmr@gmail.com>
MichaelOrlov added a commit that referenced this pull request Apr 23, 2026
)

(cherry picked from commit b7370e4)

Signed-off-by: Michael Orlov <morlovmr@gmail.com>
Co-authored-by: Michael Orlov <morlovmr@gmail.com>
@MichaelOrlov
Copy link
Copy Markdown
Contributor Author

https://github.com/Mergifyio backport jazzy

@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 23, 2026

backport jazzy

✅ Backports have been created

Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🧑‍🌾 Warning in Rolling/Jazzy ci regarding rosbag2_compression trying to check a directory size

2 participants