fix: reuse single Manifest instance for releases and pull requests#41
Merged
yafanasiev merged 1 commit intorelease-please-oss:mainfrom Apr 22, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
yafanasiev
approved these changes
Apr 22, 2026
Contributor
|
@omerarslan0 thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
main()function instantiated two separateManifestobjects: one for creating releases and another for creating pull requests. Each call toloadOrBuildManifest()triggers GitHub API requests to fetch repository configuration and release history.When
draft: trueis enabled this redundancy becomes especially costly because draft release resolution requires iterating through more GitHub API pages to find tagged releases, effectively doubling the API overhead.This PR hoists the
loadOrBuildManifest()call above both conditional blocks so a single, shared instance is used for both operations.Originally opened against the upstream
googleapis/release-please-actionin #1190; rebased here per maintainer request.Test plan
npm testpassesnpm run buildregeneratesdist/index.jsnpm run lintandnpm run fmt:checkpass