fix: reuse single Manifest instance for releases and pull requests#1190
Open
omerarslan0 wants to merge 3 commits intogoogleapis:mainfrom
Open
fix: reuse single Manifest instance for releases and pull requests#1190omerarslan0 wants to merge 3 commits intogoogleapis:mainfrom
omerarslan0 wants to merge 3 commits intogoogleapis:mainfrom
Conversation
omerarslan0
force-pushed
the
fix/reuse-manifest-instance-v2
branch
from
2a7784f to
0ba6600
Compare
Author
|
@chingor13 Can you look this? |
ferrarimarco
approved these changes
Mar 16, 2026
Author
|
@ferrarimarco Is there any progress? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main() function previously instantiated two separate Manifest objects: one for creating releases and another for creating pull requests. Each call to loadOrBuildManifest() triggered GitHub API requests to fetch repository configuration and release history.
When draft: true is enabled, this redundancy becomes especially costly because draft release resolution requires iterating through more GitHub API pages to find tagged releases, effectively doubling the API overhead.
This PR hoists the loadOrBuildManifest() call above both conditional blocks so a single, shared instance is used for both operations.
Fixes #1169