ci: Sync R-CMD-check workflow from cynkratemplate - #592
Closed
krlmlr wants to merge 4 commits into
Closed
Conversation
Sync .github/workflows/R-CMD-check.yaml and .github/workflows/versions-matrix/action.R from cynkratemplate (cynkra/cynkratemplate#95). The rcc-full job now applies the generic "env" field of test matrix entries to $GITHUB_ENV itself, before the custom actions run, because composite actions cannot read the matrix context. This repo does not use the "env" field, so behavior is unchanged; the sync keeps the workflow identical across template consumers and makes the generic mechanism available without any custom amendments.
Ubuntu 26.04 moved the legacy System V-style time zones into the separate tzdata-legacy package. DBItest's timestamp roundtrip specs call lubridate::with_tz(tzone = "PST8PDT"), which warns "Unrecognized time zone" when the zone is missing, and testthat promotes the warning to a failure — the rcc-smoke job has been failing this way on main since the runners moved to ubuntu-26.04. Install tzdata-legacy in the custom before-install action, mirroring the same fix in duckdb-r.
krlmlr
changed the title
Resolve the conflict in the custom before-install action in favor of main's tzdata-legacy step (#593), which supersedes the equivalent step added on this branch.
krlmlr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync
.github/workflows/R-CMD-check.yamland.github/workflows/versions-matrix/action.Rfrom cynkratemplate(cynkra/cynkratemplate#95):
the
rcc-fulljob now applies the genericenvfieldof test matrix entries to
$GITHUB_ENVitself,before the custom actions run,
because composite actions cannot read the
matrixcontext.This repo does not use the
envfield,so behavior is unchanged;
the sync keeps the workflow identical across template consumers
and makes the generic mechanism available
without any custom amendments.
An earlier revision of this PR also installed
tzdata-legacyto fix the
PST8PDTfailures in the DBItest timestamp specs;that fix landed on
mainindependently as #593and this branch now carries
main's version of the step(conflict resolved in its favor).
🤖 Generated with Claude Code
https://claude.ai/code/session_0136C9bRMjBGkUrtLdkYNmAg