Rebuild docs top nav to match the marketing header#19133
Conversation
Replaces the legacy docs-top-nav.html with a data-driven implementation that mirrors header/nav.html: Tailwind utility classes, the shared github-star-button partial, and CSS-only auth-aware Sign in / Dashboard swap. - Nav contents now live in data/docs_nav.yaml (logo dropdown, items, CTAs) - Logo dropdown handler moved out of packages.ts into header-nav.ts - Drops theme/src/scss/docs/_docs-top-nav.scss and the top-nav-user-toggle.html partial; both are superseded by the new markup - header_nav.yaml: books -> book-open for icon consistency - Pre-paint inline script in head.html sets <html class="is-signed-in"> from the pulumi_web_user_info cookie, with unlayered CSS rules driving the [data-nav-loggedout]/[data-nav-dashboard] swap. Replaces the post-hydration JS toggle so the swap happens before first paint and contributes nothing to CLS for signed-in users. The docs nav intentionally does not stick to the top of the viewport and does not ship a mobile hamburger sheet -- below lg, the docs sidebar is the primary nav surface. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Pre-merge Review — Last updated 2026-05-18T20:42:25ZTip Summary: Infrastructure refactor that rebuilds the docs top-nav partial ( Review confidence:
Investigation log
🔍 Verification trail4 claims extracted · 2 verified · 0 unverifiable · 0 contradicted
🚨 Outstanding in this PRNo outstanding findings in this PR.
|
CamSoper
left a comment
There was a problem hiding this comment.
This looks great to me, @jeffmerrick!
|
Hopefully not jumping the gun here, but would love to see this out, so clicking the button! 🚀🚀🚀 |
Updates the docs nav to match the marketing nav more closely. I also swapped in a different icon for docs (just prefer how it looks.)
Future work: implement same nav in registry and guides.
(pulumi/registry#10814 and https://github.com/pulumi/guides/issues/108)
Resolves #18834
Generated description of changes:
Replaces the legacy
docs-top-nav.htmlwith a data-driven implementation thatmirrors
header/nav.html: Tailwind utility classes, the sharedgithub-star-buttonpartial, and the same auth-aware Sign in / Dashboardtoggle (
data-nav-loggedout/data-nav-dashboard).data/docs_nav.yaml(logo dropdown, items, CTAs)packages.tsintoheader-nav.tstheme/src/scss/docs/_docs-top-nav.scssand thetop-nav-user-toggle.htmlpartial; both are superseded by the new markupheader_nav.yaml:books->book-openfor icon consistencyNotes:
does not ship a mobile hamburger sheet -- below
lg, the docs sidebar isthe primary nav surface.