Skip to content

Update docs-nav Get Started button to match pulumi.com#10937

Closed
alexleventer wants to merge 2 commits into
masterfrom
alexleventer/docs-nav-get-started-button
Closed

Update docs-nav Get Started button to match pulumi.com#10937
alexleventer wants to merge 2 commits into
masterfrom
alexleventer/docs-nav-get-started-button

Conversation

@alexleventer
Copy link
Copy Markdown
Contributor

@alexleventer alexleventer commented May 8, 2026

Summary

Brings the Pulumi Registry docs top-nav Get Started button in line with the live pulumi.com/docs button — class, color, and destination.

  • Class + href: switch the button from .get-started-header-button to .btn .btn-primary (matches the markup pulumi.com/docs renders) and point it at https://app.pulumi.com/signup instead of /docs/get-started/.
  • Brand violet: pulumi.com uses --color-violet-primary: #5a30c5 (a deeper, more saturated violet); this repo had #805ac3. Updated $brand-violet, --color-violet-600 (the Tailwind v4 token bg-violet-600 resolves to), and the violet endpoints of brand gradients in _header.scss, _docs-top-nav.scss, and _pulumi-up.scss, plus the active-link bullet in _docs-main.scss. The multi-stop brand-rainbow gradients (_about.scss, _pricing.scss, etc.) were left alone — #805ac3 there is one stop in a fixed designed sequence, not a "violet-600" reference.
  • .btn default: switched the .btn rule in _buttons.scss and the higher-priority @utility btn in main.scss from blue-600violet-600 (with violet-500 hover/active). Both definitions had to change because @utility btn lives in Tailwind's utilities layer and overrides the _buttons.scss components-layer rule.
  • Dead-CSS cleanup: removed the now-orphan .get-started-header-button rules in _docs-top-nav.scss (lines 36, 52–68) — they were scoped under nav.actually-docs and no longer matched anything after the markup switch.

Scope

This PR is intentionally limited to the docs top-nav (docs-top-nav.html / nav.actually-docs). The regular top-nav (top-nav.html, used on the registry index and package pages) still uses the legacy .get-started-header-button class and links to /docs/get-started/. Bringing the registry-side nav in line with pulumi.com is a separate visual change that warrants its own review and QA pass; tracking as a follow-up.

Test plan

  • make build-assets produces a fresh bundle (verified locally — new hash bundle-registry.67d9a125.css).
  • make serve and load a docs/registry page; confirm the Get Started button in the top nav is now violet (#5a30c5), not blue.
  • Hover the button and confirm the hover state still looks right.
  • Click the button and confirm it navigates to https://app.pulumi.com/signup.
  • Spot-check other pages that use .btn (e.g. /docs/continuous-delivery, get-started-stepper shortcodes) to confirm they render in violet without regressions.
  • Spot-check pages using bg-violet-600 directly (any badges, marketing CTAs) to confirm the brand-color shift looks intentional rather than off.

🤖 Generated with Claude Code

- Switch button from .get-started-header-button to .btn .btn-primary so
  it renders consistently with the live pulumi.com/docs top nav, and
  point it at https://app.pulumi.com/signup (the conversion target
  used on pulumi.com).
- Update brand violet from #805ac3 to #5a30c5 to match pulumi.com's
  --color-violet-primary. Updated $brand-violet, --color-violet-600,
  and the remaining hardcoded #805ac3 references used as the violet
  endpoint of brand gradients (_header.scss hover state,
  _docs-top-nav.scss, _pulumi-up.scss btn-primary hover) and the
  docs-main active-link bullet. Left the multi-stop brand rainbow
  gradients alone since #805ac3 there is one stop in a fixed sequence,
  not a violet-600 reference.
- Switch the .btn / @Utility btn default colors from blue-600 to
  violet-600 (with violet-500 hover/active) so .btn alone renders in
  brand violet on registry pages, matching pulumi.com.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@claude
Copy link
Copy Markdown

claude Bot commented May 8, 2026

Registry Review — PR #10937

Thanks for the detailed PR description — it makes the rationale for the global .btn and --color-violet-600 shifts easy to follow. Two real issues worth fixing before merge, plus a couple of QA notes.

Issues

1. Orphaned CSS in themes/default/theme/src/scss/docs/_docs-top-nav.scss (lines 36 and 52–68)

The rules in this file are scoped under nav.actually-docs (line 1), and nav.actually-docs is rendered exclusively by themes/default/layouts/partials/docs-top-nav.html. After this PR changes that template's button from class="get-started-header-button" to class="btn btn-primary", the selectors that target .get-started-header-button no longer match anything in the rendered DOM:

  • Line 36: div.get-started a.get-started-header-button { margin-left: 0; }
  • Lines 52–68: the entire div.get-started { a.get-started-header-button { … } } block (gradient background, border, hover, etc.)

Notably, lines 60 and 62 of _docs-top-nav.scss are updated in this PR to swap #805ac3#5a30c5, but those edits land on rules that no longer apply to anything — wasted churn and misleading for future readers. Suggest deleting both blocks:

        div.logo-get-started {
            display: flex;
            align-items: center;
            gap: 18px;

            @media (min-width: 640px){
                gap: 36px;
            }
        }

…and removing the div.get-started { a.get-started-header-button { … } } block at lines 52–69 entirely (the surrounding div.get-started { display: none; } / responsive display: flex; rules at lines 109 and 133–137 are unaffected).

2. Inconsistency with the regular top-nav at themes/default/layouts/partials/top-nav.html:32

top-nav.html (rendered on non-docs pages, including the registry index/package pages) still uses the old class and href:

<a class=\"get-started-header-button\" data-track=\"get-started-practitioner-nav\" href=\"/docs/get-started/\">Get Started</a>

The PR title and description scope this work to "docs-nav," so this may be intentional — but the result is that on registry pages the Get Started button still goes to /docs/get-started/ and renders with the old pill/gradient style, while docs pages use the new violet .btn linking to app.pulumi.com/signup. Worth confirming whether registry pages should also update to match, or whether this divergence is by design. If the latter, a one-line note in the PR body (or a follow-up issue) would help future maintainers understand why the two navs differ.

QA notes (not blockers)

  • Global .btn color shift (_buttons.scss lines 8 and 11–15, main.scss line 24): every plain .btn across the site changes from blue to violet. The test plan covers /docs/continuous-delivery and get-started-stepper shortcodes — worth also eyeballing any registry-specific CTA that uses bare .btn.
  • --color-violet-600 token reassignment (_theme.scss:58): anything using bg-violet-600, text-violet-600, or theme(\"colors.violet.600\") (e.g. _header.scss:104, _header.scss:498, _header.scss:503) now resolves to #5a30c5. The selective-vs-global decision called out in the PR description is sound; just flagging the blast radius for visual QA.
  • .btn-primary is a marker class here: I didn't find a global .btn-primary rule — only section-scoped ones (e.g. _marketing.scss, _self-hosted.scss, _pulumi-up.scss). For the docs-nav button, all visible styling will come from .btn. That matches the PR description's stated intent ("matches the markup pulumi.com/docs renders"), so no action needed — just confirming.

Mention @claude if you'd like another pass after addressing the dead-CSS cleanup or want help untangling the regular-vs-docs nav split.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Your site preview for commit a570ee3 is ready! 🎉

http://registry--origin-pr-10937-a570ee3b.s3-website.us-west-2.amazonaws.com/registry.

After switching docs-top-nav.html's button to .btn .btn-primary, the
.get-started-header-button selectors in _docs-top-nav.scss no longer
match anything in the rendered DOM (this file is scoped under
nav.actually-docs).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Your site preview for commit 502a8e1 is ready! 🎉

http://registry--origin-pr-10937-502a8e1c.s3-website.us-west-2.amazonaws.com/registry.

Copy link
Copy Markdown
Collaborator

@CamSoper CamSoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexleventer Sorry I missed this!

This needs one more thing: It doesn't respond when you mouseover like the main docs site.

@CamSoper
Copy link
Copy Markdown
Collaborator

Actually you may want to hold off on this, it appears @jeffmerrick is already working on it

@jeffmerrick
Copy link
Copy Markdown

Ah yep, @alexleventer I have a new docs nav going here: pulumi/docs#19133 that I'll pull over to registry and guides (along with all the other type, color, icon, etc. updates).

@github-actions
Copy link
Copy Markdown
Contributor

Site previews for this pull request have been removed. ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants