build: export CXXFLAGS#224
Merged
Merged
Conversation
14 tasks
Darchiv
previously approved these changes
Mar 11, 2025
badochov
force-pushed
the
badochov/export-cxxflags
branch
from
72b6da6 to
9b1cf53
Compare
Darchiv
reviewed
Mar 12, 2025
| ### right now we should have only target-necessary flags, save them for exporting (for building ports) ### | ||
| EXPORT_CFLAGS := $(CFLAGS) | ||
| EXPORT_CXXFLAGS := $(CXXFLAGS) | ||
| EXPORT_CPPFLAGS := $(CPPFLAGS) |
Member
There was a problem hiding this comment.
Why is CPPFLAGS needed? It leaks phoenix-specific flags like NOMMU
Author
There was a problem hiding this comment.
It is not needed after all my bad.
badochov
force-pushed
the
badochov/export-cxxflags
branch
2 times, most recently
from
5c6d553 to
6757f3d
Compare
JIRA: RTOS-1013
badochov
force-pushed
the
badochov/export-cxxflags
branch
from
6757f3d to
5274de1
Compare
Darchiv
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: RTOS-1013
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment