Skip to content

openssl: specify c and ldflags to configure#94

Closed
badochov wants to merge 1 commit into
masterfrom
badochov/nocflags
Closed

openssl: specify c and ldflags to configure#94
badochov wants to merge 1 commit into
masterfrom
badochov/nocflags

Conversation

@badochov

@badochov badochov commented Mar 6, 2025

Copy link
Copy Markdown

JIRA: RTOS-1013

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: ia32

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@badochov
badochov requested a review from Darchiv March 6, 2025 14:50
@github-actions

github-actions Bot commented Mar 6, 2025

Copy link
Copy Markdown

Unit Test Results

7 958 tests  ±0   7 416 ✅ ±0   43m 33s ⏱️ +25s
  470 suites ±0     542 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit a050f47. ± Comparison against base commit 1994dc6.

♻️ This comment has been updated with latest results.

@badochov
badochov force-pushed the badochov/nocflags branch 3 times, most recently from 9ac8be9 to 272a9e0 Compare March 11, 2025 15:46
Comment thread openssl/30-phoenix.conf Outdated
@@ -15,7 +15,6 @@ my %targets = (
cc => "arm-phoenix-gcc",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use CC, AS, LD, AR env vars instead of hardcoding toolchain names?

This will probably require creating a configuration file from a template. Maybe if using a template file, include paths wouldn't break the build, as is the case with passing via command parameters.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea, and includes no longer break the build

@badochov
badochov force-pushed the badochov/nocflags branch 4 times, most recently from 257bc39 to 4ea264d Compare March 14, 2025 11:50
@badochov
badochov force-pushed the badochov/nocflags branch from 4ea264d to a050f47 Compare March 14, 2025 11:54
@badochov
badochov requested a review from Darchiv March 14, 2025 12:07
@adamgreloch

Copy link
Copy Markdown
Member

will be superseded by #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants