Skip to content

pthread: make pthread sched-related functions POSIX-compliant#504

Open
adamgreloch wants to merge 4 commits into
masterfrom
adamgreloch/RTOS-1364
Open

pthread: make pthread sched-related functions POSIX-compliant#504
adamgreloch wants to merge 4 commits into
masterfrom
adamgreloch/RTOS-1364

Conversation

@adamgreloch

@adamgreloch adamgreloch commented Jul 10, 2026

Copy link
Copy Markdown
Member

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: damianloew/posix_tests
  • Tested by hand on: riscv64

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several POSIX-compliant scheduling functions, including sched_setparam, sched_getparam, sched_setscheduler, sched_getscheduler, and sched_rr_get_interval, and updates the pthread library to support scheduling parameter management. The review identifies several areas where error handling and return values need to be adjusted to strictly adhere to POSIX standards, specifically regarding error propagation and return values for scheduling functions.

Comment thread pthread/pthread.c
Comment thread pthread/pthread.c
Comment thread pthread/pthread.c
Comment thread pthread/pthread.c
Comment thread pthread/pthread.c Outdated
Comment thread pthread/pthread.c
@adamgreloch adamgreloch force-pushed the adamgreloch/RTOS-1364 branch 3 times, most recently from 0e91ffa to 85344ca Compare July 13, 2026 10:40
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

Unit Test Results

10 890 tests  ±0   10 220 ✅ ±0   52m 37s ⏱️ - 4m 4s
   680 suites ±0      670 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 2ca5da8. ± Comparison against base commit d0a2884.

♻️ This comment has been updated with latest results.

@adamgreloch adamgreloch marked this pull request as ready for review July 13, 2026 12:44
@adamgreloch adamgreloch requested a review from a team July 13, 2026 12:44
@adamgreloch adamgreloch force-pushed the adamgreloch/RTOS-1364 branch from 85344ca to 2ca5da8 Compare July 13, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant