Fix part of #5607: Prevent toolbar title truncation in AudioLanguageFragment at 200% font scaling#6135
Conversation
…ment at 200% font scaling
|
Hi @anmoltrvd01, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
|
Hi @BenHenning, PTAL when you have time. |
|
Deferring to @adhiamboperes for review. |
|
Hi @anmoltrvd01, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
|
Hi @adhiamboperes, it looks like the comment coverage workflow requires manual approval for first-time contributors, so the coverage checks are currently failing. Could you please approve and re-run the workflow when you have time? |
adhiamboperes
left a comment
There was a problem hiding this comment.
@anmoltrvd01, apologies for the delayed review.
I have left a suggestion for how to test the changes, otherwise good job so far.
app/src/main/java/org/oppia/android/app/options/AudioLanguageActivityPresenter.kt
Show resolved
Hide resolved
|
Hi @adhiamboperes, I've addressed the requested changes by adding the test for toolbar marquee behavior in 'AudioLanguageActivityTest' and fixing the formatting issues. |
|
@anmoltrvd01, the new test is failing. Please fix it and run it locally. We have included the test running instructions in the installation guide of the wiki. |
|
Hi @anmoltrvd01, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
|
Hi @adhiamboperes, |
adhiamboperes
left a comment
There was a problem hiding this comment.
Thanks @anmoltrvd01, PTAL at some final cleanup comments.
Also:
- Don't resolve comments - the reviewer will resolve comments after verifying that they have been addressed fully.
- Always re-assign the PR to the reviewer when done making changes. If you're unsure how to reassign this PR to a reviewer, please make sure to review the wiki page that details the Guidance on submitting PRs.
app/src/sharedTest/java/org/oppia/android/app/options/AudioLanguageActivityTest.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/android/app/options/AudioLanguageActivityTest.kt
Outdated
Show resolved
Hide resolved
|
@adhiamboperes PTAL |
adhiamboperes
left a comment
There was a problem hiding this comment.
Looks good so far, thanks!
Waiting for CI to pass.
|
Assigning @BenHenning for code owner reviews. Thanks! |
|
PTAL when you get a chance @adhiamboperes, I’m a bit unsure about the current CI failures. It’s been a few days and I’m not completely clear on what is still blocking the PR from passing all checks. |
|
Unassigning @anmoltrvd01 since a re-review was requested. @anmoltrvd01, please make sure you have addressed all review comments. Thanks! |
Coverage ReportResultsNumber of files assessed: 74 Passing coverageFiles with passing code coverage
Exempted coverageFiles exempted from coverage
|
|
✨ Fantastic work @anmoltrvd01! Your very first PR to Oppia has been merged! 🎉🥳 You've just taken your first step into open-source, and we couldn’t be happier to have you onboard. 🙌 For any support, feel free to reach out to the developer onboarding lead: @adhiamboperes. Happy coding! 👩💻👨💻 |


Explanation
Fix part of #5607 (PR 11: Settings & Help)
This PR addresses a UI issue in AudioLanguageFragment where the toolbar title was truncated when the system font size was increased to 200% (Android 14+).
Changes made:
Testing performed:
Tested all fragments in PR 11: Settings & Help with font scaling set to 200% on an Android 14 emulator.
Results:
Only AudioLanguageFragment required a fix.
Screenshots (before/after) are attached below:
Before: Toolbar title truncated at 200% font scaling.
After: Marquee effect scrolls the title instead of truncating (see attached recording).
PreferredAudioLang.mp4
(Enabled 200% font scaling & Tested with maximum Display Size setting.)
Screen.Recording.2026-03-07.160639.mp4
The recording shows navigation through each screen confirming that only AudioLanguageFragment required a fix.