Fix part of #5607: Prevent toolbar title truncation in AudioLanguageFragment at 200% font scaling#6110
Fix part of #5607: Prevent toolbar title truncation in AudioLanguageFragment at 200% font scaling#6110anmoltrvd01 wants to merge 3 commits intooppia:developfrom
Conversation
…ment at 200% font scaling
|
Hi @adhiamboperes, |
|
Hi @anmoltrvd01, We typically don't make the toolbar text wrap, but we have an option called marquee, you can see an example of thei in TopicActivity and ExplorationActivity, please take a look at those and let me know if you have any questions. |
adhiamboperes
left a comment
There was a problem hiding this comment.
Thanks @anmoltrvd01! please make the changes I have suggested, and I will run your CI checks. I know that because the current changes are only xml related, the checks would pass.
e3581ce to
700dd15
Compare
6ba11cd to
a1d9c28
Compare
a1d9c28 to
f9bb109
Compare
|
Hi @anmoltrvd01, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
|
Hi @adhiamboperes, |
adhiamboperes
left a comment
There was a problem hiding this comment.
Thanks @anmoltrvd01! This solution is now in the correct direction. Could you please do the same to the rest of teh activities under "PR 11: Settings & Help" so that we can mark the checkbox as completed when your PR is merged?
However, please note that because this PR was force-pushed, you need to create a duplicate PR and copy both your changes and the nicely written PR description(including the before/after evidence).
In the wiki, force-pushing is prohibited because it changes the revision history. Only use merge and not rebase, and if you change something in your code, just create a new commit since you cannot ammend any that has been pushed already.
|
Hi @adhiamboperes, New PR: #6135This new PR includes the marquee implementation and verification for all fragments under PR 11: Settings & Help with 200% font scaling. Please let me know if any further changes are needed. |
Explanation
Fix part of #5607 (PR 11: Settings & Help)
This PR addresses a UI issue in AudioLanguageFragment where the toolbar title was truncated when the system font size was increased to 200% (Android 14+, non-linear font scaling).
Changes made:
Testing performed:
Screenshots (before/after) are attached below:
Before
After
PreferredAudioLang.mp4
(Enabled 200% font scaling & Tested with maximum Display Size setting.)