Skip to content

IPsec: add support for DNS search domains in address pools #10639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tkuehling wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

IPsec: add support for DNS search domains in address pools #10639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/opnsense/mvc/app/controllers/OPNsense/IPsec/forms/dialogPool.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,12 @@
<allownew>true</allownew>
<help>DNS servers to push as configuration payload (RFC4306 3.15 - Value 3 and 10). Accepts multiple IPv4/IPv6 addresses.</help>
</field>
<field>
<id>pool.domains</id>
<label>DNS Search Domain(s)</label>
<type>select_multiple</type>
<style>tokenize</style>
<allownew>true</allownew>
<help>DNS search domains to push as configuration payload. Accepts multiple domains.</help>
</field>
</form>
3 changes: 3 additions & 0 deletions src/opnsense/mvc/app/models/OPNsense/IPsec/Swanctl.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,9 @@
<AsList>Y</AsList>
<ValidationMessage>Entry is not a valid IPv4 or IPv6 address.</ValidationMessage>
</dns>
<domains type="TextField">

@Monviech Monviech Aug 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also use ChatGPT frequently for coding, did it really suggest a TextField here?

Please add proper validation.
https://docs.opnsense.org/development/frontend/models_fieldtypes.html

<Required>N</Required>

@Monviech Monviech Aug 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a default and can be removed

</domains>
</Pool>
</Pools>
<VTIs>
Expand Down