IPsec: add support for DNS search domains in address pools - #10639
Draft
tkuehling wants to merge 1 commit into
Draft
IPsec: add support for DNS search domains in address pools#10639tkuehling wants to merge 1 commit into
tkuehling wants to merge 1 commit into
Conversation
Monviech
reviewed
Aug 3, 2026
| <AsList>Y</AsList> | ||
| <ValidationMessage>Entry is not a valid IPv4 or IPv6 address.</ValidationMessage> | ||
| </dns> | ||
| <domains type="TextField"> |
Member
There was a problem hiding this comment.
I also use ChatGPT frequently for coding, did it really suggest a TextField here?
Please add proper validation.
https://docs.opnsense.org/development/frontend/models_fieldtypes.html
Monviech
reviewed
Aug 3, 2026
| <ValidationMessage>Entry is not a valid IPv4 or IPv6 address.</ValidationMessage> | ||
| </dns> | ||
| <domains type="TextField"> | ||
| <Required>N</Required> |
Member
There was a problem hiding this comment.
This is a default and can be removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
If AI was used, please disclose:
Describe the problem
This change exposes the strongSwan
domainspool option in the OPNsense IPsec GUI.The backend already supports arbitrary pool attributes, therefore no PHP or configuration generator changes are required. This PR only extends the MVC model and the pool dialog.
Describe the proposed solution
The
domainsoption configures the IKEv2 Configuration PayloadINTERNAL_DNS_DOMAIN, allowing clients to automatically receive one or more DNS search domains.This enables clients to resolve short host names such as nas, printer, fileserver instead of requiring fully qualified names.
Related issue
No issues were created, because this feature was missing.