Skip to content

IPsec: add support for DNS search domains in address pools - #10639

Draft
tkuehling wants to merge 1 commit into
opnsense:masterfrom
tkuehling:feature/ipsec-dns-search-domains
Draft

IPsec: add support for DNS search domains in address pools#10639
tkuehling wants to merge 1 commit into
opnsense:masterfrom
tkuehling:feature/ipsec-dns-search-domains

Conversation

@tkuehling

Copy link
Copy Markdown

Important notices

Before you submit a pull request, we ask you kindly to acknowledge the following:

If AI was used, please disclose:

  • Model used: ChatGPT

Describe the problem

This change exposes the strongSwan domains pool option in the OPNsense IPsec GUI.

The backend already supports arbitrary pool attributes, therefore no PHP or configuration generator changes are required. This PR only extends the MVC model and the pool dialog.


Describe the proposed solution

The domains option configures the IKEv2 Configuration Payload INTERNAL_DNS_DOMAIN, allowing clients to automatically receive one or more DNS search domains.

This enables clients to resolve short host names such as nas, printer, fileserver instead of requiring fully qualified names.


Related issue

No issues were created, because this feature was missing.

<AsList>Y</AsList>
<ValidationMessage>Entry is not a valid IPv4 or IPv6 address.</ValidationMessage>
</dns>
<domains type="TextField">

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also use ChatGPT frequently for coding, did it really suggest a TextField here?

Please add proper validation.
https://docs.opnsense.org/development/frontend/models_fieldtypes.html

<ValidationMessage>Entry is not a valid IPv4 or IPv6 address.</ValidationMessage>
</dns>
<domains type="TextField">
<Required>N</Required>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a default and can be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants