Skip to content

[pattern-fly-5] Increase Playwright viewport height to 1080#2053

Closed
openshift-cherrypick-robot wants to merge 1 commit into
openshift:pattern-fly-5from
openshift-cherrypick-robot:cherry-pick-2050-to-pattern-fly-5
Closed

[pattern-fly-5] Increase Playwright viewport height to 1080#2053
openshift-cherrypick-robot wants to merge 1 commit into
openshift:pattern-fly-5from
openshift-cherrypick-robot:cherry-pick-2050-to-pattern-fly-5

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jun 10, 2026

Copy link
Copy Markdown

This is an automated cherry-pick of #2050

/assign kyoto

Summary by CodeRabbit

  • Tests
    • Updated test environment browser viewport configuration to expand test coverage across different screen resolutions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

The Playwright test configuration viewport height is increased from 900 to 1080 pixels, keeping the width at 1440 pixels. This changes the default browser dimensions used during test execution and screenshot capture.

Changes

Viewport Configuration Update

Layer / File(s) Summary
Viewport height adjustment
playwright.config.ts
Browser viewport height increased from 900 to 1080 pixels in the use.viewport configuration, affecting all Playwright test rendering and screenshots.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

lgtm, approved

Suggested reviewers

  • joshuawilson
  • xrajesh

Poem

🐰 A viewport grows taller, one-eighty it claims,
From nine-hundred pixels to show broader frames,
The playwright adjusts with a keystroke so neat,
Tests rendering wider—a pixel-perfect feat! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately describes the main change: increasing the Playwright viewport height to 1080 in the configuration file.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from joshuawilson and kyoto June 10, 2026 08:08
@openshift-ci

openshift-ci Bot commented Jun 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign syedriko for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyoto kyoto changed the title [pattern-fly-5] 4.19: Increase Playwright viewport height to 1080 [pattern-fly-5] Increase Playwright viewport height to 1080 Jun 11, 2026
@kyoto

kyoto commented Jun 12, 2026

Copy link
Copy Markdown
Member

Superseded by #2059

@kyoto kyoto closed this Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants