Skip to content

4.19: Increase Playwright viewport height to 1080#2050

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.19from
kyoto:4.19-increase-test-viewport-height
Jun 10, 2026
Merged

4.19: Increase Playwright viewport height to 1080#2050
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.19from
kyoto:4.19-increase-test-viewport-height

Conversation

@kyoto

@kyoto kyoto commented Jun 10, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Tests
    • Updated test viewport resolution to 1440×1080 for improved consistency in test execution and screenshot capture.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@kyoto kyoto added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 10, 2026
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 89ca2afa-0183-4464-b93f-127b57ff8d08

📥 Commits

Reviewing files that changed from the base of the PR and between c362249 and 9d5bb95.

📒 Files selected for processing (1)
  • playwright.config.ts

📝 Walkthrough

Walkthrough

This PR updates the Playwright test runner's viewport configuration, increasing the browser height from 900 to 1080 pixels while maintaining the width at 1440 pixels. This single-line change affects all browser-based tests and screenshot captures.

Changes

Viewport Configuration

Layer / File(s) Summary
Viewport height configuration
playwright.config.ts
The Playwright use.viewport height is increased from 900 to 1080 pixels, expanding vertical rendering space for test execution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A viewport grew taller today,
From nine-hundred to eighty plus ten,
More pixels for tests at play,
The browser sits happier then! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: increasing the Playwright viewport height from 900 to 1080 pixels.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from joshuawilson and xrajesh June 10, 2026 07:23
@openshift-ci

openshift-ci Bot commented Jun 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci

openshift-ci Bot commented Jun 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit eac5222 into openshift:release-4.19 Jun 10, 2026
5 checks passed
@kyoto kyoto deleted the 4.19-increase-test-viewport-height branch June 10, 2026 08:06
@kyoto

kyoto commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

/cherry-pick main

@kyoto

kyoto commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

/cherry-pick pattern-fly-5

@openshift-cherrypick-robot

Copy link
Copy Markdown

@kyoto: new pull request created: #2052

Details

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown

@kyoto: new pull request created: #2053

Details

In response to this:

/cherry-pick pattern-fly-5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants