Skip to content

Modifications to gnmi1.27,gnmi_sample_mode_test.go #5390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
divyarema wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Modifications to gnmi1.27,gnmi_sample_mode_test.go #5390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion feature/gnmi/subscribe/tests/gnmi_sample_mode_test/gnmi_sample_mode_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ func TestISISProtocol(t *testing.T) {

// Starting ISIS protocol takes some time to converge. So we may not receive ISIS data
// in the first sample after configuration.
samples := niStream.Nexts(5)
samples := niStream.Nexts(10)
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Increasing the sample count to 10 introduces inconsistencies with the test documentation and reporting:

  • README Inconsistency: The README.md (Test 3) specifies that telemetry should be received within 5 samples. Per the repository guidelines (line 29), the code must align with the test plan. Please update the README to reflect the new requirement.
  • Error Message Inconsistency: The error message on line 149 (not in this diff) mentions 3 samples. This should be updated to match the code to avoid confusion during failures.
  • Efficiency: niStream.Nexts(10) blocks for the full duration of 10 intervals (approx. 110s) before processing. Consider refactoring the loop to call niStream.Next() individually to allow the test to exit as soon as the first valid sample is received, rather than always waiting for the maximum count.
References
  1. Code should follow the steps and requirements documented in the test README.md. (link)


updated := false
for idx, sample := range samples {
Expand Down
Loading