Modifications to gnmi1.27,gnmi_sample_mode_test.go

[divyarema]

Increased the no of samples collected to avoid false failures in virtual platforms

[OpenConfigBot]

Pull Request Functional Test Report for #5390 / 1c96667

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		gNMI-1.27: gNMI Sample Mode Test
Cisco 8000E		gNMI-1.27: gNMI Sample Mode Test
Cisco XRd		gNMI-1.27: gNMI Sample Mode Test
Juniper ncPTX		gNMI-1.27: gNMI Sample Mode Test
Nokia SR Linux		gNMI-1.27: gNMI Sample Mode Test
Openconfig Lemming		gNMI-1.27: gNMI Sample Mode Test

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		gNMI-1.27: gNMI Sample Mode Test
Cisco 8808		gNMI-1.27: gNMI Sample Mode Test
Juniper PTX10008		gNMI-1.27: gNMI Sample Mode Test
Nokia 7250 IXR-10e		gNMI-1.27: gNMI Sample Mode Test

Help

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adjusts the sample collection count in the gNMI sample mode test suite. The change is intended to prevent intermittent test failures caused by timing issues during protocol convergence on virtualized environments.

Highlights

• Sample Collection Increase: Increased the number of samples collected in the ISIS protocol test from 5 to 10 to improve test stability on virtual platforms.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request increases the sample count for the ISIS protocol stream from 5 to 10 to account for convergence time. Feedback was provided regarding inconsistencies this change introduces with the test documentation and error messages, as well as an opportunity to improve test efficiency by processing samples individually rather than blocking for the full sample set.

[gemini-code-assist]

Increasing the sample count to 10 introduces inconsistencies with the test documentation and reporting:

• README Inconsistency: The README.md (Test 3) specifies that telemetry should be received within 5 samples. Per the repository guidelines (line 29), the code must align with the test plan. Please update the README to reflect the new requirement.
• Error Message Inconsistency: The error message on line 149 (not in this diff) mentions 3 samples. This should be updated to match the code to avoid confusion during failures.
• Efficiency: niStream.Nexts(10) blocks for the full duration of 10 intervals (approx. 110s) before processing. Consider refactoring the loop to call niStream.Next() individually to allow the test to exit as soon as the first valid sample is received, rather than always waiting for the maximum count.

References

1. Code should follow the steps and requirements documented in the test README.md. ^(link)