Skip to content

this is a fix for 498145557 (Arista Failing FNT: feature/qos/ingress_policer/otg_tests/ingress_police_nhg) #5387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mihaitomaro wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

this is a fix for 498145557 (Arista Failing FNT: feature/qos/ingress_policer/otg_tests/ingress_police_nhg) #5387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion feature/qos/ingress_policer/otg_tests/ingress_police_nhg/ingress_police_nhg_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ func configureGribi(t *testing.T, dut *ondatra.DUTDevice) {
fluent.NextHopGroupEntry().
WithNetworkInstance(deviations.DefaultNetworkInstance(dut)).
WithID(nhgID).
AddNextHop(nhID, uint64(i+1)),
AddNextHop(nhID, 1),
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The weight for the Next Hop Group member is changed from uint64(i+1) to 1. While this change likely addresses the failure on Arista for this specific configuration, a similar pattern of using non-unit weights for single-member Next Hop Groups exists in programBasicEntries (line 471). If the platform issue is related to weights in single-member groups, programBasicEntries should also be updated to ensure the test passes consistently across the entire suite.

References
  1. Maintaining consistency in code patterns across the test suite is important, especially when applying a fix for a platform-specific issue that likely affects multiple locations using the same pattern.

)

// --- Create IPv6 route triggering MPLS-in-UDP encapsulation ---
Expand Down
Loading