this is a fix for 498145557 (Arista Failing FNT: feature/qos/ingress_policer/otg_tests/ingress_police_nhg)

[mihaitomaro]

https://partnerissuetracker.corp.google.com/u/2/issues/498145557
Adding a fix for the above BUG

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a specific failure observed in the ingress_police_nhg test suite on Arista hardware. By adjusting the weight parameter in the NextHopGroup entry, the configuration is now aligned with expected device behavior, ensuring stability for the associated quality of service tests.

Highlights

• Next Hop Group Configuration: Updated the NextHopGroup configuration to use a static weight of 1 instead of a dynamic index-based weight to resolve test failures on Arista devices.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5387 / 7274c8b

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		DP-2.2: QoS scheduler with 1 rate 2 color policer, classifying on next-hop group
Cisco 8000E		DP-2.2: QoS scheduler with 1 rate 2 color policer, classifying on next-hop group
Cisco XRd		DP-2.2: QoS scheduler with 1 rate 2 color policer, classifying on next-hop group
Juniper ncPTX		DP-2.2: QoS scheduler with 1 rate 2 color policer, classifying on next-hop group
Nokia SR Linux		DP-2.2: QoS scheduler with 1 rate 2 color policer, classifying on next-hop group
Openconfig Lemming		DP-2.2: QoS scheduler with 1 rate 2 color policer, classifying on next-hop group

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		DP-2.2: QoS scheduler with 1 rate 2 color policer, classifying on next-hop group
Cisco 8808		DP-2.2: QoS scheduler with 1 rate 2 color policer, classifying on next-hop group
Juniper PTX10008		DP-2.2: QoS scheduler with 1 rate 2 color policer, classifying on next-hop group
Nokia 7250 IXR-10e		DP-2.2: QoS scheduler with 1 rate 2 color policer, classifying on next-hop group

Help

[gemini-code-assist]

Code Review

This pull request modifies the configureGribi function in the ingress policer NHG test to use a constant weight of 1 for next hop group members instead of a dynamic weight. The reviewer noted that this change, while likely addressing a platform-specific failure, should be applied consistently to other parts of the test suite, such as programBasicEntries, to ensure uniform behavior.

[gemini-code-assist]

The weight for the Next Hop Group member is changed from uint64(i+1) to 1. While this change likely addresses the failure on Arista for this specific configuration, a similar pattern of using non-unit weights for single-member Next Hop Groups exists in programBasicEntries (line 471). If the platform issue is related to weights in single-member groups, programBasicEntries should also be updated to ensure the test passes consistently across the entire suite.

References

1. Maintaining consistency in code patterns across the test suite is important, especially when applying a fix for a platform-specific issue that likely affects multiple locations using the same pattern.