Skip to content

[deviations] Remove deprecated_vlan_id usage from ARISTA devaitions #5371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yini101 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[deviations] Remove deprecated_vlan_id usage from ARISTA devaitions #5371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion feature/bgp/ate_tests/bgp_long_lived_graceful_restart/metadata.textproto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ platform_exceptions: {
deviations: {
omit_l2_mtu: true
interface_config_vrf_before_address: true
deprecated_vlan_id: true
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since deprecated_vlan_id is being removed from all affected tests (as indicated in the PR description and confirmed by the Arista-specific comment in proto/metadata.proto), please follow the complete "Removing Deviations" process as defined in the repository style guide (lines 145-163). This includes removing the accessor function from internal/deviations/deviations.go, reserving the field number (73) in proto/metadata.proto, and running make proto/metadata_go_proto/metadata.pb.go to update the generated Go code.

References
  1. Guidelines for removing deviations from the repository, including updating deviations.go and metadata.proto. (link)

interface_enabled: true
require_routed_subinterface_0: true
default_network_instance: "default"
Expand Down
3 changes: 1 addition & 2 deletions feature/interface/aggregate/otg_tests/aggregate_subinterface_test/metadata.textproto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ platform_exceptions: {
deviations: {
interface_enabled: true
default_network_instance: "default"
deprecated_vlan_id: true
require_routed_subinterface_0: true
}
}
}
1 change: 0 additions & 1 deletion feature/p4rt/otg_tests/traceroute_packetin_with_vrf_selection_test/metadata.textproto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ platform_exceptions: {
}
deviations: {
gnoi_subcomponent_path: true
deprecated_vlan_id: true
interface_enabled: true
static_protocol_name: "STATIC"
default_network_instance: "default"
Expand Down
Loading