[deviations] Remove deprecated_vlan_id usage from ARISTA devaitions#5371
[deviations] Remove deprecated_vlan_id usage from ARISTA devaitions#5371yini101 wants to merge 1 commit intoopenconfig:mainfrom
Conversation
EOS supports the newer single-tagged vlan-id leaf which means deprecated_vlan_id should not be used anymore. The deviation affected RT-5.14, P4RT-5.3, and RT-1.14.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request cleans up Arista platform deviations by removing the deprecated_vlan_id flag. This change aligns the test configurations with current EOS capabilities, which now support the standard vlan-id leaf, ensuring better compatibility and adherence to updated standards. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated_vlan_id deviation from several test metadata files, including BGP long-lived graceful restart, aggregate subinterface, and P4RT traceroute tests. Feedback was provided regarding the incomplete removal process; specifically, the deviation should also be removed from the central deviations.go and metadata.proto files, and the generated Go code should be updated accordingly.
| deviations: { | ||
| omit_l2_mtu: true | ||
| interface_config_vrf_before_address: true | ||
| deprecated_vlan_id: true |
There was a problem hiding this comment.
Since deprecated_vlan_id is being removed from all affected tests (as indicated in the PR description and confirmed by the Arista-specific comment in proto/metadata.proto), please follow the complete "Removing Deviations" process as defined in the repository style guide (lines 145-163). This includes removing the accessor function from internal/deviations/deviations.go, reserving the field number (73) in proto/metadata.proto, and running make proto/metadata_go_proto/metadata.pb.go to update the generated Go code.
References
- Guidelines for removing deviations from the repository, including updating deviations.go and metadata.proto. (link)
2 participants
EOS supports the newer single-tagged vlan-id leaf which means deprecated_vlan_id should not be used anymore. The deviation affected RT-5.14, P4RT-5.3, and RT-1.14.