-
Notifications
You must be signed in to change notification settings - Fork 311
Project Proposal: Audit Logging SIG #2409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 8 commits
5094fb1
9337b7f
75f2c57
f81c2f4
65ae32e
776b821
6dd519d
2ec002d
d7e265f
405ddb5
0adb8e5
a5ef343
711dc46
087865c
3876a31
8b38626
066501b
70cbac4
a6b34f1
6bc9a5e
e03dcd8
86bd77a
41329f3
03d1de1
2f9813f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,71 @@ | ||||||||||||||||
| # Audit Logging | ||||||||||||||||
|
|
||||||||||||||||
| ## Background and description | ||||||||||||||||
|
|
||||||||||||||||
| Audit logging describes the capability of capturing audit-trail relevant events of a system to meet compliance requirements. Such events may originate from the infrastructure (e.g. a Kubernetes cluster) up to the application-level. It is a capability that is particularly relevant for providers of enterprise software. | ||||||||||||||||
|
|
||||||||||||||||
| Unlike regular application logs, audit logs are usually subject to long retention periods and software providers must guarantee their completeness (i.e. guarantee of delivery). | ||||||||||||||||
|
|
||||||||||||||||
| Examples of audit logs include: | ||||||||||||||||
| - permission changes (e.g. of a service account or application user) | ||||||||||||||||
| - modification of data | ||||||||||||||||
| - accessing sensitive information | ||||||||||||||||
| - failed login attempts | ||||||||||||||||
|
|
||||||||||||||||
| ### Current challenges | ||||||||||||||||
|
|
||||||||||||||||
| Audit Logging is currently not within the scope of OpenTelemetry | ||||||||||||||||
|
mlenkeit marked this conversation as resolved.
Outdated
|
||||||||||||||||
|
|
||||||||||||||||
| - no semantic conventions for audit logs in OTel | ||||||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Can you provide some examples of what would be part of such semantic conventions? My knowledge on audit logs is very limited, so it would help to understand the problem much better.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @svrnm our experience has shown that in order to analyze audit logs at scale, it is important to define an (extensible) event catalog. The event catalog standardizes audit log events across workloads/produces. For example, our internal event catalog currently consists of 50+ such events. Ideally, such a catalog would be part of semantic conventions. To make this more tangible, I've added some examples to the appendix of the document: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. another examples from the security world is https://github.com/ocsf.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thanks @mlenkeit. Makes it much clearer The For the I am just making those things up to exemplify the difference, they will probably take a different form or shape eventually, so to make a long story short, here is a suggestion to rephrase:
Suggested change
@renewelches thanks for calling out OCSF, if I remember correctly there were conversations in the past between OTel and OCSF, cc @lmolkova
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Regarding I understand how "semantic conventions for audit logs" can be misleading. To me, the suggestion that you made has a notion of particularly describe logs that are "already there" (e.g. events emitted by a K8s cluster) and can be considered relevant for audit purposes. Especially in enterprise software, it's common that applications produce logs that are specifically mean to be audit logs (and nothing else). To me, it' s important that we find wording that covers these two types that we do have. How about the following?
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As mentioned in another comment, this all depends on what attributes are changeable or must be immutable. As of my understanding an attribute could be altered by a processor in the collector. Which is something we would want to avoid or want to prevent in cases of audit logs. If we conclude that we can or should only guarantee immutability for the log itself then we must live with replication/doublication. Otherwise we might have to add the constrain that also certain attributes must be immutable.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1 to looking into OCSF for security events and borrowing relevant semantic conventions from there.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @mlenkeit security semconv SIG is also working on introducing security related attributes to the semconv, we have currently discussion around user authentication. I feel that this SIG and security SIG might have some common tasks/discussions |
||||||||||||||||
| - OTel APIs/SDKs do not provide feedback to the application level whether data (in particular logs) have been successfully delivered to a remote endpoint. To guarantee delivery, either the SDK has to give those guarantees, or provide feedback to the application so that it can take care of guaranteed delivery itself. | ||||||||||||||||
| - OTel collectors may lose audit logs in transit (i.e. no guarantee of delivery) | ||||||||||||||||
|
svrnm marked this conversation as resolved.
Outdated
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does "OTel collectors" mean the "OpenTelemetry Collector" (https://github.com/open-telemetry/opentelemetry-specification/tree/main/specification#project-naming) or "any collectors that can handle OpenTelemetry data (whether OTLP or something else)"?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||||||||||||
|
|
||||||||||||||||
| ### Goals, objectives, and requirements | ||||||||||||||||
|
|
||||||||||||||||
| The goal of this project is to make OTel fit for audit logging purposes that meet compliance requirements of enterprise software providers, in particular: | ||||||||||||||||
|
|
||||||||||||||||
| - REQ-CONV-01: Semantic conventions for application-level audit logs are defined | ||||||||||||||||
| - REQ-CONV-02: Semantic conventions for infrastructure-level audit logs are defined | ||||||||||||||||
| - REQ-APPL-01: Guaranteed delivery of audit logs exported via OpenTelemetry SDK | ||||||||||||||||
| - REQ-PIPE-01: OTel collector must provide guaranteed delivery of audit logs, including when its process is interrupted | ||||||||||||||||
|
|
||||||||||||||||
| ## Deliverables | ||||||||||||||||
|
|
||||||||||||||||
| - semantic convention for audit logs | ||||||||||||||||
| - extend OTel APIs/SDKs for audit logging purposes (in collaboration with the respective SIG) | ||||||||||||||||
| - extend OTel collector for audit logging purposes (in collaboration with the respective SIG) | ||||||||||||||||
|
|
||||||||||||||||
| ## Staffing / Help Wanted | ||||||||||||||||
|
|
||||||||||||||||
| The following vendors are interested in improving this area: | ||||||||||||||||
| - SAP (@mlenkeit, @FWinkler79) | ||||||||||||||||
| - Microsoft (@reyang) | ||||||||||||||||
|
|
||||||||||||||||
| Other vendors are invited to join the discussion. | ||||||||||||||||
|
|
||||||||||||||||
| ### Required staffing | ||||||||||||||||
|
|
||||||||||||||||
| * Project lead: SAP (name tbd) | ||||||||||||||||
| * Sponsors: | ||||||||||||||||
| - Reiley Yang (@reyang) | ||||||||||||||||
| - tbd | ||||||||||||||||
| * GC liaison: tbd | ||||||||||||||||
|
mlenkeit marked this conversation as resolved.
Outdated
|
||||||||||||||||
| * Engineers: | ||||||||||||||||
| * SAP will provide a prototype in two languages (tbd; likely two of Java, JavaScript, Go) | ||||||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we need prototype in two parts:
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for pointing this out! It's clear to us, but I'll work on making this clearer in the doc... |
||||||||||||||||
| * Maintainers/approvers: tbd | ||||||||||||||||
|
|
||||||||||||||||
| ## Timeline | ||||||||||||||||
|
|
||||||||||||||||
| TBD based on community involvement. | ||||||||||||||||
|
|
||||||||||||||||
| ## Labels | ||||||||||||||||
|
|
||||||||||||||||
| - audit-logging (tbc) | ||||||||||||||||
|
|
||||||||||||||||
| ## Project Board | ||||||||||||||||
|
|
||||||||||||||||
| TODO: add link | ||||||||||||||||
|
|
||||||||||||||||
| ## SIG Meetings and Other Info | ||||||||||||||||
|
|
||||||||||||||||
| TODO: add information | ||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good points! In addition, these are something we might want to consider:
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reyang thanks for mentioning these points.
Especially the API behavior is something that we had thought about initially. However, when we first pitched audit logging on Slack, we received the following comment from Ted Young:
Based on this initial feedback, we decided to file this SIG proposal without proposing such API changes.