This repository was archived by the owner on Mar 2, 2026. It is now read-only.
1208-bug-move-nft-from-child-broken - #1210
Merged
Merged
Conversation
PR SummaryTemporarily disabled the NFT move functionality from child chain due to missing script implementation. The change maintains the send functionality while preventing users from attempting to move NFTs, which was causing errors. Also improved the back button behavior in the registration flow to only appear when there's a valid history state. Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Files Processed (2)
- src/ui/views/Linked/LinkedNftDetail.tsx (3 hunks)
- src/ui/views/NFT/Detail.tsx (1 hunk)
Actionable Comments (0)
Skipped Comments (3)
-
src/ui/views/NFT/Detail.tsx [54-54]
maintainability: "State variable initialized but never used"
-
src/ui/views/Linked/LinkedNftDetail.tsx [483-483]
best practice: "TODO comment with far future date"
-
src/ui/views/NFT/Detail.tsx [58-58]
best practice: "TODO comment with far future date"
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Files Processed (1)
- src/ui/views/Welcome/Register/index.tsx (3 hunks)
Actionable Comments (0)
Skipped Comments (1)
-
src/ui/views/Welcome/Register/index.tsx [72-73]
readability: "Navigation condition could be simplified for better readability"
zzggo
approved these changes
Jul 24, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #1208
Summary of Changes
Turned off move from child until we can fix it properly. Send still seems to work
Also fixed back button on create new profile
Need Regression Testing
Risk Assessment
Additional Notes
The user can still use send to send an nft from child to parent