Merge from master#1214
Conversation
2.9.1 master
Corrected type issue getting the evm address when requesting accounts
…ar-on-import Fixed back button and seed phrase import padding
1208-bug-move-nft-from-child-broken
…ken-part2 1208-bug-move-nft-from-child-broken-part2
PR SummaryFixed multiple issues including EVM address type handling, NFT movement from child accounts, navigation in profile import/registration flows, and UI improvements. Temporarily disabled NFT movement from child accounts due to missing script functionality. Enhanced wallet loading checks and improved back button behavior across different views. Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (11)
1208-bug-move-nft-from-child-broken-part2
- 4eef8fc: Re-enabled move button for main accounts
Closes #1208
- fd50b70: Now wants til wallet is loaded before redirecting
Closes #1208
1208-bug-move-nft-from-child-broken
- b493005: Corrected back button on create new profile
Closes #1208
- 39d72a9: Turn off moving NFT from child until we can redo it
Closes #1208
Fixed back button and seed phrase import padding
- b98c662: Fixed back button and seed phrase import padding
Closes #1206
Corrected type issue getting the evm address when requesting accounts
- daf7c18: Corrected type issue getting the evm address when requesting accounts
Closes #1204
2.9.1 master
Files Processed (8)
- src/background/controller/provider/controller.ts (2 hunks)
- src/ui/components/PrivateRoute.tsx (2 hunks)
- src/ui/components/password/PasswordTextarea.tsx (1 hunk)
- src/ui/views/Linked/LinkedNftDetail.tsx (3 hunks)
- src/ui/views/NFT/Detail.tsx (1 hunk)
- src/ui/views/SortHat.tsx (2 hunks)
- src/ui/views/Welcome/Register/index.tsx (3 hunks)
- src/ui/views/Welcome/import-profile/index.tsx (4 hunks)
Actionable Comments (1)
-
src/ui/views/NFT/Detail.tsx [56-56]
possible bug: "Potential unhandled edge case in wallet check"
Skipped Comments (2)
-
src/background/controller/provider/controller.ts [248-249]
enhancement: "Potential error message improvement needed"
-
src/ui/views/Welcome/import-profile/index.tsx [111-119]
possible issue: "Potential navigation flow issue"
| // TB July 2025. This always fails as the script doesn't exist. Turning off for now | ||
| // const [canMoveChild, setCanMoveChild] = useState(false); | ||
|
|
||
| const canMoveChild = activeAccountType !== 'child' && currentWallet.address; |
There was a problem hiding this comment.
The condition currentWallet.address might throw if currentWallet is null/undefined. Consider adding a null check: activeAccountType !== 'child' && currentWallet?.address
Related Issue
Closes #1202
Closes #1206
Closes #1204
Closes #1208