Skip to content
This repository was archived by the owner on Mar 2, 2026. It is now read-only.

Corrected type issue getting the evm address when requesting accounts#1205

Merged
tombeckenham merged 1 commit into
masterfrom
1204-bug-error-returning-evmaddress
Jul 23, 2025
Merged

Corrected type issue getting the evm address when requesting accounts#1205
tombeckenham merged 1 commit into
masterfrom
1204-bug-error-returning-evmaddress

Conversation

@tombeckenham

Copy link
Copy Markdown
Contributor

Related Issue

Closes #1204

Summary of Changes

Corrected a type issue in ethRequestAccounts

Need Regression Testing

Recheck dApp connections

  • Yes
  • No

Risk Assessment

  • Low
  • Medium
  • High

@tombeckenham tombeckenham linked an issue Jul 23, 2025 that may be closed by this pull request
@github-actions

github-actions Bot commented Jul 23, 2025

Copy link
Copy Markdown

PR Summary

Enhanced the EVM address retrieval logic in the provider controller to properly handle the EVM account type. Updated the code to correctly extract the address property from the EVM account object, adding proper type safety and validation checks. This fixes issue #1204 related to dApp connections.

Changes

File Summary
src/background/controller/provider/controller.ts Fixed type handling in ProviderController by properly typing evmAddress as string and correctly extracting address from evmAccount object. Added null checks and improved validation logic for EVM addresses in both initial query and approval flow.

autogenerated by presubmit.ai

@tombeckenham
tombeckenham changed the base branch from dev to master July 23, 2025 05:10

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (2)
  • daf7c18: Corrected type issue getting the evm address when requesting accounts

Closes #1204

2.9.1 master

Files Processed (1)
  • src/background/controller/provider/controller.ts (2 hunks)
Actionable Comments (0)
Skipped Comments (2)
  • src/background/controller/provider/controller.ts [248-251]

    maintainability: "Potential duplicate error handling logic"

  • src/background/controller/provider/controller.ts [238-238]

    best practice: "Variable type declaration could be more specific"

@tombeckenham
tombeckenham merged commit 12e40fa into master Jul 23, 2025
8 of 10 checks passed
@github-actions github-actions Bot mentioned this pull request Jul 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Error returning evmAddress

2 participants