This repository was archived by the owner on Mar 2, 2026. It is now read-only.
Corrected type issue getting the evm address when requesting accounts#1205
Merged
Conversation
PR SummaryEnhanced the EVM address retrieval logic in the provider controller to properly handle the EVM account type. Updated the code to correctly extract the address property from the EVM account object, adding proper type safety and validation checks. This fixes issue #1204 related to dApp connections. Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (2)
- daf7c18: Corrected type issue getting the evm address when requesting accounts
Closes #1204
2.9.1 master
Files Processed (1)
- src/background/controller/provider/controller.ts (2 hunks)
Actionable Comments (0)
Skipped Comments (2)
-
src/background/controller/provider/controller.ts [248-251]
maintainability: "Potential duplicate error handling logic"
-
src/background/controller/provider/controller.ts [238-238]
best practice: "Variable type declaration could be more specific"
tombeckenham
had a problem deploying
to
development
July 23, 2025 05:11 — with
GitHub Actions
Failure
zzggo
approved these changes
Jul 23, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #1204
Summary of Changes
Corrected a type issue in ethRequestAccounts
Need Regression Testing
Recheck dApp connections
Risk Assessment