-
Notifications
You must be signed in to change notification settings - Fork 503
prov/efa: Remove handshake requirement for DC #12169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,145 @@ | ||
| /* SPDX-License-Identifier: BSD-2-Clause OR GPL-2.0-only */ | ||
| /* SPDX-FileCopyrightText: Copyright Amazon.com, Inc. or its affiliates. All rights reserved. */ | ||
|
|
||
| #include <stdio.h> | ||
| #include <stdlib.h> | ||
| #include <getopt.h> | ||
| #include <rdma/fi_errno.h> | ||
| #include <rdma/fi_ext.h> | ||
| #include <shared.h> | ||
| #include "benchmarks/benchmark_shared.h" | ||
|
|
||
| /* | ||
| * Mirrors ft_init_fabric() but inserts fi_setopt(HOMOGENEOUS_PEERS) | ||
| * before fi_enable, since the option must be set before enabling the EP | ||
| * to avoid the requirement for a handshake before using a read based | ||
| * protocol. | ||
| */ | ||
| static int init_fabric_with_homogeneous_peers(void) | ||
| { | ||
| int ret; | ||
| bool homogeneous = true; | ||
|
|
||
| ret = ft_init(); | ||
| if (ret) | ||
| return ret; | ||
|
|
||
| ret = ft_init_oob(); | ||
| if (ret) | ||
| return ret; | ||
|
|
||
| if (oob_sock >= 0 && opts.dst_addr) { | ||
| ret = ft_sock_sync(oob_sock, 0); | ||
| if (ret) | ||
| return ret; | ||
| } | ||
|
|
||
| ret = ft_getinfo(hints, &fi); | ||
| if (ret) | ||
| return ret; | ||
|
|
||
| ret = ft_open_fabric_res(); | ||
| if (ret) | ||
| return ret; | ||
|
|
||
| ret = ft_alloc_active_res(fi); | ||
| if (ret) | ||
| return ret; | ||
|
|
||
| /* Must be set before fi_enable to skip handshake requirement before | ||
| * using read based protocol */ | ||
| ret = fi_setopt(&ep->fid, FI_OPT_ENDPOINT, | ||
| FI_OPT_EFA_HOMOGENEOUS_PEERS, | ||
| &homogeneous, sizeof(homogeneous)); | ||
| if (ret) { | ||
| FT_PRINTERR("fi_setopt(HOMOGENEOUS_PEERS)", ret); | ||
| return ret; | ||
| } | ||
|
|
||
| ret = ft_enable_ep_recv(); | ||
| if (ret) | ||
| return ret; | ||
|
|
||
| if (oob_sock >= 0 && !opts.dst_addr) { | ||
| ret = ft_sock_sync(oob_sock, 0); | ||
| if (ret) | ||
| return ret; | ||
| } | ||
|
|
||
| ret = ft_init_av(); | ||
| if (ret) | ||
| return ret; | ||
|
|
||
| return 0; | ||
| } | ||
|
|
||
| static int run(void) | ||
| { | ||
| int ret; | ||
| char test_name[64] = ""; | ||
|
|
||
| ret = init_fabric_with_homogeneous_peers(); | ||
| if (ret) | ||
| return ret; | ||
|
|
||
| init_test(&opts, test_name, sizeof(test_name)); | ||
| ret = bandwidth(); | ||
| if (ret) | ||
| return ret; | ||
|
|
||
| return ft_finalize(); | ||
| } | ||
|
|
||
| int main(int argc, char **argv) | ||
| { | ||
| int op, ret, cleanup_ret; | ||
|
|
||
| opts = INIT_OPTS; | ||
| opts.options |= FT_OPT_BW; | ||
| opts.iterations = 1; | ||
| opts.warmup_iterations = 0; | ||
| opts.transfer_size = 262144; /* 256 KB */ | ||
| opts.window_size = 1; | ||
|
|
||
| hints = fi_allocinfo(); | ||
| if (!hints) | ||
| return EXIT_FAILURE; | ||
|
|
||
| while ((op = getopt_long(argc, argv, "Uh" CS_OPTS INFO_OPTS BENCHMARK_OPTS, | ||
| long_opts, &lopt_idx)) != -1) { | ||
| switch (op) { | ||
| default: | ||
| if (!ft_parse_long_opts(op, optarg)) | ||
| continue; | ||
| ft_parse_benchmark_opts(op, optarg); | ||
| ft_parseinfo(op, optarg, hints, &opts); | ||
| ft_parsecsopts(op, optarg, &opts); | ||
| break; | ||
| case 'U': | ||
| hints->tx_attr->op_flags |= FI_DELIVERY_COMPLETE; | ||
| break; | ||
| case '?': | ||
| case 'h': | ||
| ft_csusage(argv[0], | ||
| "Verify runt read protocol transfers " | ||
| "data with both RTM packets and RDMA read"); | ||
| ft_benchmark_usage(); | ||
| ft_longopts_usage(); | ||
| return EXIT_FAILURE; | ||
| } | ||
| } | ||
|
|
||
| if (optind < argc) | ||
| opts.dst_addr = argv[optind]; | ||
|
|
||
| hints->ep_attr->type = FI_EP_RDM; | ||
| hints->caps = FI_MSG; | ||
| hints->mode |= FI_CONTEXT | FI_CONTEXT2; | ||
| hints->domain_attr->mr_mode = opts.mr_mode; | ||
| hints->addr_format = opts.address_format; | ||
|
|
||
| ret = run(); | ||
|
|
||
| cleanup_ret = ft_free_res(); | ||
| return ft_exit_code(ret ? ret : cleanup_ret); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I would name it generally like fi_efa_rdm_bw_homogeneous_peer