prov/efa: Remove handshake requirement for DC#12169
Merged
Merged
Conversation
sunkuamzn
force-pushed
the
dc-remove-handshake
branch
from
24fad5c to
2757eeb
Compare
shijin-aws
reviewed
Apr 23, 2026
shijin-aws
previously approved these changes
Apr 23, 2026
sunkuamzn
force-pushed
the
dc-remove-handshake
branch
from
2757eeb to
3b7397d
Compare
shijin-aws
approved these changes
Apr 24, 2026
| prov/efa/src/fi_efa_mmap_test \ | ||
| prov/efa/src/fi_efa_mr_test | ||
| prov/efa/src/fi_efa_mr_test \ | ||
| prov/efa/src/fi_efa_runt_read_no_handshake |
Contributor
There was a problem hiding this comment.
Nit: I would name it generally like fi_efa_rdm_bw_homogeneous_peer
This commit removes the handshake requirement for delivery complete protocol. It treats delivery complete as a baseline feature supported by all endpoints starting v2.0. Signed-off-by: Sai Sunku <sunkusa@amazon.com>
Update the docs to reflect the requirement that handshake is no longer required for delivery complete. Added the "baseline" terminology which allows extra features and requests to be considered universally available in v2.0. Signed-off-by: Sai Sunku <sunkusa@amazon.com>
The previous test used fi_rdm_bw and relied on ft_sync enforcing the handshake because the delivery complete protocol required a handshake (see ofiwg#9864). The previous commits remove the requirement for the handshake, so this commit introduces a new test that sets the FI_OPT_EFA_HOMOGENEOUS_PEERS setopt to remove the handshake requirement and enable the use of read based protocols right away. Signed-off-by: Sai Sunku <sunkusa@amazon.com>
sunkuamzn
force-pushed
the
dc-remove-handshake
branch
from
3b7397d to
b7b21ff
Compare
a-szegel
reviewed
Apr 27, 2026
a-szegel
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the handshake requirement for delivery complete protocol