Repository navigation
fix(cli): publish the npm command line as strings-le - #57
Merged
Merged
Conversation
npm refused string-le as too close to the older package stringle, so 2.6.0 was tagged but never published anywhere. The package is now strings-le and still installs the string-le command. Every surface moves to 2.6.1 so the release has a tag of its own. build-cli.js now holds the command name rather than the package name, check-cli-package.js fails on any README npx that names a package this repo does not publish, and release-cli.yml reads the package name from cli/package.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm refused
string-le(403, too close tostringle), so 2.6.0 was never published. The npm package becomesstrings-le. It still installs thestring-lecommand, held byte for byte to the crate.v2.6.0stays as it is.build-cli.jschecks the command name, not the package name.check-cli-package.jsfails when a README'snpxnames a package this repo does not publish. Checked by puttingnpx string-leback into the README.release-cli.ymlreads the package name fromcli/package.json.Local: typecheck, lint, 508 tests, crate fmt/clippy/tests, cli-package, cli-parity (59 commands), mcp-bundle, npm-package, fleet.