Repository navigation
Quiet stdout at a terminal - #55
Merged
Merged
Conversation
stdout skips the JSON reports when it is a terminal, since the stderr listing already covers a person reading it. Piped or redirected output is unchanged, byte for byte. --values keeps printing at a terminal, because asking for the values is asking to see them.
A patch bump: the JSON on stdout is unchanged in shape and content. Only the terminal case, where nothing reads it, goes quiet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stdout skips the JSON reports when it is a terminal; the stderr listing already covers a person. Piped or redirected output is unchanged. --values still prints at a terminal. Every string was already listed on stderr and the crate prints no path it did not receive, so nothing else changed.
Version: crate 0.4.4 (patch, JSON unchanged). Not published.
Local verification: fmt, clippy -D warnings and cargo test --locked pass (253 unit tests plus integration suites). Fresh binary at a pty prints no JSON and still prints --values; piped prints JSON.