Repository navigation
fix: bind no key by default - #44
Merged
Merged
Conversation
The extension bound one command to a Ctrl+Alt key out of the box. Three extensions in the family used the same key for it, and several of the others sat on keys the editor or the operating system already uses, so with more than one installed the shortcut was a coin toss. The default is removed. Every command is still declared, so each can be given a key under Keyboard Shortcuts. The README and the Help command name the command to run where they used to name the key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the one default keyboard shortcut this extension shipped.
Why
Each extension in the family bound its main command to a
Ctrl+Altkey. Three of them used the same key, and several others sat on keys the editor or the operating system already uses. With more than one installed, which command a key ran was unpredictable.What this changes
contributes.keybindingsfrom the manifest.Every command is still declared and registered, so users can bind any of them under Keyboard Shortcuts. No version bump and no tag.