Repository navigation
ci: publish the npm package with the NPM_TOKEN secret - #43
Merged
Merged
Conversation
The release workflow published to npm by trusted publishing, which was never set up on npm for this package. The step failed every time it ran, and every version so far was published with a token outside the workflow. The release of this version reached the Marketplace and Open VSX and stopped at npm for that reason. The npm job now authenticates with the NPM_TOKEN secret, the token the whole family is published with, and checks it is set before doing anything that cannot be undone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow's npm step used trusted publishing, which was never configured on npm, so it has failed on every run. This switches it to the
NPM_TOKENrepository secret, the token the family's packages are published with, and adds a check that the secret is set.Workflow and guide only. Nothing that ships changes.