Repository navigation
Capacity on conditions and caps, two tutorials, and fixes to runs and evidence - #726
Merged
Merged
Conversation
…ondition resolves (#731)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Seven issues from the board, one commit each, with eight problems found on the way, each filed and fixed here in a commit of its own.
cap_workersin an overlay or a schedule caps a group, andmuructl scale APP --cap N --for Dsets a temporary cap.muructl scale statusshowscapped: at most N workers from NAME. The drain is ascaling.decisionnaming the overlay, and preview shows the cap.request_share{app=...}never saw a rate-limited crawler. It is now counted under the application it was routed to, as a maintenance refusal already was.muructl applynow warns of an overlay whose client class route sends the class to a snapshot while its condition reads that class's share of the application. The overlays guide's and the specification's crawler example did exactly that; it now uses a rate limit.latch = true, which is what the warning advises.muructl overlay listsizes its columns to their content, soactive (condition)and cooldown states line up.forreadunknown:with no reason.condition listnow shows it aspending, andcondition showgives the wait, aspending: when has held for 4s of 10sorfiring since ...; clear_when has held for 2s of 5s.ConditionStatusgainspending_since_unix_ms.latch, hold capacity on the condition, and cap by hand. Test:test_tutorial_responding_to_traffic.py.muructl runs of one project, commands reach the newest, by a start time now recorded inrun.json, and name the others with their--socket. A run started beside another of its project says so at start-up.muructl run, the requests the edge still has in flight on that worker, for a worker stopped whole. Such a request has no record yet, so the recorder keeps the capture until the record opens (at most 64, for two minutes).muructl runwatches a project inside a directory the enclosing repository ignores as a whole by its own.gitignorealone, and says so. A run with no file to watch says that too. A project in an ignored part of a monorepo keeps the repository's rules.timeout 10mwherecommand listprints600s.before_forkgate with a failing one refused,exclusive, a detached backup followed, stopped and outliving a daemon restart, and a cleanup on a schedule with a skipped run. Placed after first-canary in the index, so the first four tutorials stay in order. Test:test_tutorial_commands_and_migrations.py, made sooner by also running the scheduleat_bootafter a restart from nothing.Design choices
#712 (ADR 0065; specification 7.5 "Caps", 9.10 and 19.1):
min_workersand a static count.muructl applywarns of a declared floor above another overlay's or schedule's cap on the same group. One overlay refuses a cap below its own floor, or besidemax_workers.--capwaits until the serving release's group is at or under the cap;--no-waitreturns at once.APP:cap(APP:cap:GROUP), apart from the floor'sAPP:scale, so each ends on its own.--capsays so rather than waiting.cap_workersis a schedule key too.max_step_up.#714: reach the newest run, with a note naming the others and their
--socket, as suggested (specification 13.8).#715: this departs in part from the suggested approach of the edge's in-flight list alone. The host asks a condemned worker to give up its requests before the kill, and the edge answers them at once, so by the time the kill event arrives the edge no longer lists them. That is exactly the GIL-held case in the issue. The worker's answer to that request names them without the interpreter, so it is the main source. The edge's list is kept for a worker stopped whole, which can answer nothing. Recorded in specification 11.7, "Captures".
#723:
parents(false)alone would drop a monorepo's root rules. Instead, a watched directory that the enclosing repository ignores as a whole, and that is not a repository of its own, is walked by its own ignore files alone, as git would treat it as a repository (specification 9.8).Checks
just lint, andjust test(665 Rust, 11 extension and 162 Python tests);tests/pythonwith the native extension hidden (161 passed)just test-integrationlocally: 789 passed, 5 skippedtests/python, and the integration files touched: liveness, soft timeout, capacity, client classes, run admin, reload, conditions, overlays and both new tutorials (63 passed)muructl apply --dry-runjust docsandjust referenceCloses #711
Closes #712
Closes #713
Closes #714
Closes #715
Closes #717
Closes #723
Closes #724
Closes #725
Closes #727
Closes #728
Closes #729
Closes #730
Closes #731
🤖 Generated with Claude Code