Skip to content

The responding-to-traffic tutorial test can end its load before its condition resolves #731

Closed

Description

@GrahamDumpleton

Summary

tests/integration/test_tutorial_responding_to_traffic.py, added on the branch for #713, failed on the macOS integration job of PR #726: wait_for(lambda: "state resolved since" in show()) after the short burst timed out.

Cause

The burst load(12, 6) sends the people's requests for 12 s and the crawlers' for 6 s. With the test's shortened windows, the condition resolves about 13 s in (the crawlers stop at 6 s, the 5 s window takes about 4 s more to fall under 0.2, then clear_for is 3 s). Once the load ends there is no traffic, the share has no figure, and a condition whose evaluation is unknown holds the state it had, so it stays firing and the wait times out. Locally it resolved just inside the 12 s. Steps 2 and 4 wait for resolution after their load in the same way, with a few seconds more margin.

Not a fault in Muru: a condition with no figure holding its state is the documented behaviour.

Fix

Each load runs well past when the condition can resolve, the test waits for the resolution while the load is still running, then stops the load and reads its output.

Testing

The test, run repeatedly; the macOS integration job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testingA problem in the tests or their harness rather than in Muru

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions