Generate fr/gtfs_rts_strings.xml & ignore location inside agency name.

[mmathieum]

and compat w/ stm_info_values

• Cleanup... ca-montreal-stm-subway-android#7

[gemini-code-assist]

Code Review

This pull request introduces a new shell script to generate French-localized GTFS resource strings. The review identifies several areas for improvement, including the need to refactor duplicated logic into a single script, fixing grammatical errors in the French translation, correcting the locale attribute, and improving shell script best practices such as quoting variables and simplifying file creation commands.

I am having trouble creating individual review comments. Click here to see my feedback.

shared-modules/app-android/src/main/res/values-fr/MTgtfs_rts_strings.xml.MT.sh (1)

This script is almost an identical copy of shared-modules/app-android/src/main/res/values/MTgtfs_rts_strings.xml.MT.sh. This significant code duplication will increase maintenance overhead, as any bug fix or logic change will need to be applied to both files.

A better approach would be to refactor this into a single, more generic script that can generate resource files for different languages. The language could be passed as a parameter or inferred from the script's path (e.g., from values-fr). This would make the solution more maintainable and scalable for supporting more languages in the future.

shared-modules/app-android/src/main/res/values-fr/MTgtfs_rts_strings.xml.MT.sh (51)

The variable $AGENCY_NAME_FILE is not quoted. This can lead to issues if the file path contains spaces or other special characters. It's a best practice to always quote variables representing file paths.

AGENCY_NAME_LONG=$(tail -n 1 "$AGENCY_NAME_FILE");

shared-modules/app-android/src/main/res/values-fr/MTgtfs_rts_strings.xml.MT.sh (57)

The variable $AGENCY_NAME_FILE is not quoted. This can lead to issues if the file path contains spaces or other special characters. It's a best practice to always quote variables representing file paths.

AGENCY_NAME_SHORT=$(head -n 1 "$AGENCY_NAME_FILE");

shared-modules/app-android/src/main/res/values-fr/MTgtfs_rts_strings.xml.MT.sh (70)

The variable $GTFS_RDS_VALUES_GEN_FILE is not quoted in the test ([ ... ]) command. This can lead to issues if the file path contains spaces or other special characters. It's a best practice to always quote variables representing file paths.

if [ -f "$GTFS_RDS_VALUES_GEN_FILE" ]; then

shared-modules/app-android/src/main/res/values-fr/MTgtfs_rts_strings.xml.MT.sh (73)

The variable $AGENCY_JSON_FILE is not quoted in the test ([ ... ]) command. This can lead to issues if the file path contains spaces or other special characters. It's a best practice to always quote variables representing file paths.

elif [ -f "$AGENCY_JSON_FILE" ]; then

shared-modules/app-android/src/main/res/values-fr/MTgtfs_rts_strings.xml.MT.sh (111)

The tools:locale attribute is set to en, but this file is for the French (fr) locale. This will likely cause Android Lint warnings and might lead to incorrect resource resolution. It should be set to fr.

<resources xmlns:tools="http://schemas.android.com/tools" tools:locale="fr">

shared-modules/app-android/src/main/res/values-fr/MTgtfs_rts_strings.xml.MT.sh (34-37)

These rm and touch commands are redundant. Since the script exits on line 31 if the file already exists, the rm -f on line 34 is a no-op. The touch on line 36 is also unnecessary because the cat command can create the file. You can safely remove these four lines and use > instead of >> in the cat command on line 108.

shared-modules/app-android/src/main/res/values-fr/MTgtfs_rts_strings.xml.MT.sh (86)

There's a grammatical error in the French translation. 'trains' is plural, so the adjective 'léger' should also be in its plural form, 'légers'.

    TYPE_LABEL="trains légers"; # TODO?

shared-modules/app-android/src/main/res/values-fr/MTgtfs_rts_strings.xml.MT.sh (108)

Using > here instead of >> will create the file if it doesn't exist. Since the script logic is to generate this file from scratch, > is more appropriate and allows removing the redundant rm and touch commands on lines 34-37.

cat >"${GTFS_RTS_STRINGS_FILE}" <<EOL

[Copilot]

Pull request overview

This PR updates the Android/shared module generation scripts to (1) avoid duplicating the agency location when it’s already present in the agency name, and (2) add/generated French GTFS-RT schedule label resources plus STM “service updates” messaging for Play Store descriptions.

Changes:

• Add generation support (and ignore rule) for values-fr/gtfs_rts_strings.xml.
• Prevent location duplication by only prepending/appending AGENCY_LOCATION_SHORT when it’s not already contained in the agency label.
• Extend Play Store short descriptions to mention STM service updates when stm_info_values.xml exists, plus minor French wording fixes.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
shared/app-android/MT.gitignore	Ignores generated values-fr/gtfs_rts_strings.xml.
shared-modules/MTREADME.md.MT.sh	Avoids adding location twice in README agency label.
shared-modules/gh_repo_update_details.sh	Avoids adding location twice in GitHub repo description label.
shared-modules/app-android/src/main/res/values/MTstrings.xml.MT.sh	Attempts to avoid duplicating location in LOCATION_LABEL selection.
shared-modules/app-android/src/main/res/values-fr/MTstrings.xml.MT.sh	French strings generator updates (plural fix + location de-dup attempt).
shared-modules/app-android/src/main/res/values-fr/MTgtfs_rts_strings.xml.MT.sh	New generator for French gtfs_rts_strings.xml.
shared-modules/app-android/src/main/play/listings/fr-FR/MTtitle.txt.MT.sh	Avoids duplicating location in French Play title.
shared-modules/app-android/src/main/play/listings/fr-FR/MTshort-description.txt.MT.sh	Avoids duplicating location + adds STM service updates text.
shared-modules/app-android/src/main/play/listings/fr-FR/MTfull-description.txt.MT.sh	Avoids duplicating location + minor French text tweaks.
shared-modules/app-android/src/main/play/listings/en-US/MTtitle.txt.MT.sh	Avoids duplicating location in English Play title.
shared-modules/app-android/src/main/play/listings/en-US/MTshort-description.txt.MT.sh	Avoids duplicating location + adds STM service updates text.
shared-modules/app-android/src/main/play/listings/en-US/MTfull-description.txt.MT.sh	Avoids duplicating location in English Play full description.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[mmathieum]

/gemini review

[gemini-code-assist]

Code Review

This pull request updates several shell scripts to improve the generation of app descriptions and resource strings. Key changes include logic to prevent duplicate location names in agency labels, French translation fixes, and the addition of a new script for generating French GTFS RTS strings. Feedback on the new script suggests using existing variables for path consistency, removing redundant file creation steps, quoting variables in file checks, and adding a trailing newline to the file.