Conversation
This was referenced May 6, 2026
- commons: Generate `fr/gtfs_rts_strings.xml` & ignore location inside agency name. mtransitapps/commons#730 - commons: Build(deps): Bump androidx.webkit:webkit from 1.15.0 to 1.16.0 in the androidx group across 1 directory mtransitapps/commons#731 - commons-java: Strings cleaner > FR > remove `ligne` from route long name & `station` from trip head-sign mtransitapps/commons-java#34 - parser: JSON config > + `additional_languages` & `stop_code_cleaners` mtransitapps/parser#66
mmathieum
commented
May 7, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the Montreal STM subway parser configuration from Java to JSON-based configuration files and updates project metadata. The review identifies several regressions in the new JSON configuration, including a missing regex anchor for zone information and missing cleanup rules for 'station' and trailing digits. Additionally, a suggestion was made to clarify a confusing comment regarding route colors.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lignefrom route long name &stationfrom trip head-sign commons-java#34additional_languages&stop_code_cleanersparser#66fr/gtfs_rts_strings.xml& ignore location inside agency name. commons#730Horaire... commons-android#141Jauneroute color