Skip to content

Restore hover tooltips on image grid dropdown items #11434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwunderl merged 2 commits into from
Jun 26, 2026
+2 −0
Merged

Restore hover tooltips on image grid dropdown items #11434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f6359a
Restore hover tooltips on image grid dropdown items
microbit-matt-hillsdon Jun 26, 2026
37216af
Merge branch 'master' into restore-grid-image-tooltips
microbit-matt-hillsdon Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pxtblocks/fields/field_imagedropdown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ export class FieldImageDropdown extends FieldDropdownGrid implements FieldCustom
button.setAttribute('data-value', value);
buttonImg.setAttribute('data-value', value);
buttonImg.setAttribute('aria-hidden', 'true');
button.title = content.alt;
button.appendChild(buttonImg);
this.gridItems.push(button);
buttonContainer.appendChild(button);
Expand Down
1 change: 1 addition & 0 deletions pxtblocks/fields/field_images.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ export class FieldImages extends FieldImageDropdown implements FieldCustom {
button.setAttribute('data-value', value);
buttonImg.setAttribute('data-value', value);
buttonImg.setAttribute('aria-hidden', 'true');
button.title = content.alt;
button.appendChild(buttonImg);
if (this.addLabel_) {
const buttonText = this.createTextNode_(content.alt);
Expand Down
Loading