Restore hover tooltips on image grid dropdown items#11434
Merged
jwunderl merged 2 commits intoJun 26, 2026
Merged
Conversation
PR microsoft#11373 removed `button.title` from FieldImageDropdown and FieldImages to fix screen reader output, but that also dropped the native hover tooltip that the tutorial relies on to name each icon. The screen reader fix was actually the `aria-hidden` on the (base64-src) image plus visually-hidden name text; the title only ever held the human-readable alt. Put the title back on the button so the tooltip covers the whole cell (no padding dead-zone), keeping aria-hidden so the base64 src is still never announced. OK in VoiceOver and NVDA, worst risk is duplicate output. Fixes microsoft/pxt-microbit#6964
microbit-matt-hillsdon
force-pushed
the
restore-grid-image-tooltips
branch
from
aadedd9 to
1f6359a
Compare
Contributor
|
@microbit-matt-hillsdon This looks good to me. Original PR was obviously a bit heavy-handed. |
jwunderl
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #11373 removed
button.titlefrom FieldImageDropdown and FieldImages to fix screen reader output, but that also dropped the native hover tooltip that the tutorial relies on to name each icon.The screen reader fix was actually the
aria-hiddenon the (base64-src) image plus visually-hidden name text; the title only ever held the human-readable alt. Put the title back on the button so the tooltip covers the whole cell (no padding dead-zone), keeping aria-hidden so the base64 src is still never announced. OK in VoiceOver and NVDA, worst risk is duplicate output.Fixes microsoft/pxt-microbit#6964
Draft for the moment, will get @microbit-robert to confirm I'm not missing something here tomorrow.