Skip to content

fix(skills): check codecov comment before local coverage build #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
worktrunk-bot wants to merge 1 commit into from
Closed

fix(skills): check codecov comment before local coverage build #1687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .claude/skills/running-in-ci/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,13 @@ exit 1
echo "codecov/patch not reported after 5 minutes"
exit 1
```
If it fails, investigate with `task coverage` and
`cargo llvm-cov report --show-missing-lines | grep <file>`.
If it fails, check codecov's PR comment first — it lists exactly which
files and lines lack coverage. If the uncovered lines are in
platform-specific code (`#[cfg(unix)]`), interactive TUI code, or test
infrastructure that CI doesn't exercise, conclude it's a false positive
without running local coverage. Only fall back to `task coverage` and
`cargo llvm-cov report --show-missing-lines | grep <file>` when the
uncovered lines are in core logic that should be testable.
4. Report completion only after all required checks **and** `codecov/patch` pass.

Never report "done" before CI passes — CI runs on Linux, Windows, and macOS.
Expand Down
Loading