fix(skills): check codecov comment before local coverage build - #1687
Closed
worktrunk-bot wants to merge 1 commit into
Closed
worktrunk-bot wants to merge 1 commit into
worktrunk-bot wants to merge 1 commit into
Conversation
The bot repeatedly installs cargo-llvm-cov from scratch in CI to investigate codecov/patch failures, wasting compute time. Guide it to check codecov's PR comment first — most failures can be assessed as false positives (platform- specific code, TUI code) without running local coverage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
Superseded by tend extraction (#1676). Target file ( |
Collaborator
Author
|
Understood — makes sense that the tend extraction superseded this. I'll add the codecov-comment-first triage step to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The bot repeatedly installs
cargo-llvm-covfrom scratch in CI review sessionsto investigate
codecov/patchfailures. This wastes significant compute time(~5-10 min per occurrence). The fix guides the bot to check codecov's PR comment
first — most failures can be assessed as false positives without local coverage.
Evidence: 4 occurrences across sessions (3 historical + 1 this hour in run
23424793547 reviewing PR #1683). The bot installed cargo-llvm-cov, ran the full
test suite with coverage twice (PR branch + main), consuming ~10 minutes of
compute to conclude the failure was a false positive in
#[cfg(unix)]TUI code.Root cause: The running-in-ci skill's codecov investigation step jumped
directly to
task coverage/cargo llvm-cov report, which requirescargo-llvm-cov to be installed. The skill lacked guidance to check the readily
available codecov PR comment first.
Fix: Replace the direct
task coverageinstruction with a triage step:check codecov's PR comment to identify uncovered files/lines, and only run local
coverage when the uncovered lines are in core testable logic.
Gate assessment:
Test plan
🤖 Generated with Claude Code