[LLHD][SV] Unify the ProceduralRegion trait in CIRCTSupport#10180
Merged
fzi-hielscher merged 2 commits intollvm:mainfrom Apr 13, 2026
Merged
[LLHD][SV] Unify the ProceduralRegion trait in CIRCTSupport#10180fzi-hielscher merged 2 commits intollvm:mainfrom
fzi-hielscher merged 2 commits intollvm:mainfrom
Conversation
Move the `ProceduralRegion` operation traits of the LLHD and SV dialects to a common declaration within the CIRCT support library. This should allow us to (temporarily) include procedural operations of one dialect under procedural regions of another dialect during lowering, without triggering an IR verification error. The behavior of the trait within the dialects remains unchanged.
Contributor
Author
|
CC #10172 |
uenoku
approved these changes
Apr 12, 2026
Member
uenoku
left a comment
There was a problem hiding this comment.
LGTM, do you have a plan to move ProceduralOp/NonProceduralOp traits as well?
Contributor
Author
|
Yeah, but that's the point where I'm not sure how to do it right. I'll create a draft PR later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the
ProceduralRegionoperation traits of the LLHD and SV dialects to a common declaration within the CIRCT support library. This should allow us to (temporarily) include procedural operations of one dialect under procedural regions of another dialect during lowering, without triggering an IR verification error. The behavior of the trait within the dialects remains unchanged.We will have to further consider how the trait should work transitively.
E.g., while this is now legal:
This still fails: