-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add Render as deploy Option 4 #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
410d093
7a9bfb3
85e0908
c3943c6
29b0dd6
0f4ce0e
47e1fa5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # yaml-language-server: $schema=https://render.com/schema/render.yaml.json | ||
| # | ||
| # Web Check on Render — Blueprint deploy | ||
| # Upstream: https://github.com/Lissy93/web-check | ||
| # Image: https://hub.docker.com/r/lissy93/web-check | ||
| # | ||
| # Pattern: image-wrapper (official lissy93/web-check image with Chromium). | ||
| # Optional OSINT API keys: add in Dashboard after deploy (see .env.sample). Do not | ||
| # declare them as sync:false here or Apply will prompt for every key. | ||
|
Comment on lines
+8
to
+9
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does render not have ability to declare them here, and have them filled in when the user clicks deploy? I only ask, since I think I've seen something similar done elsewhere.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It can (sync: false), but then Apply asks for every key even when they're optional. Left them for the dashboard after so the deploy stays quick. Happy to add a couple of the common ones if you'd rather. |
||
|
|
||
| previews: | ||
| generation: off | ||
|
|
||
| services: | ||
| - type: web | ||
| name: web-check | ||
| runtime: image | ||
| plan: standard | ||
| region: oregon | ||
| image: | ||
| url: docker.io/lissy93/web-check:2.1.10 | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we put this as
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep, switched it to |
||
| healthCheckPath: / | ||
| autoDeployTrigger: off | ||
| envVars: | ||
| - key: PORT | ||
| value: "3000" | ||
| - key: TRUST_PROXY | ||
| value: "1" | ||
| - key: CHROME_PATH | ||
| value: "/usr/bin/chromium" | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually not sure that this will work, on render? But I could be wrong. Did you get it working with that path?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah it works. Same path the image already sets internally, and screenshots came through on the deploy. |
||
| - key: PUPPETEER_EXECUTABLE_PATH | ||
| value: "/usr/bin/chromium" | ||
| - key: PUPPETEER_SKIP_DOWNLOAD | ||
| value: "true" | ||
| - key: API_ENABLE_RATE_LIMIT | ||
| value: "true" | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This wouldn't work on render, you won't have the right headers I don't think. Since the X-Forwarded-For header will be the render IP, not clients.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should be alright with TRUST_PROXY=1. That's what makes Express pick up the real client IP from X-Forwarded-For instead of Render's. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the right link though? I'd of thought it would need to point to this repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Button now goes to
render.com/deploy?repo=https://github.com/Lissy93/web-checkso it deploys from this repo.