Add Render as deploy Option 4 - #319
Conversation
Includes a Blueprint render.yaml using the official lissy93/web-check image so one-click deploy works from this fork.
Upstream may not include render.yaml yet; point to the gallery template as well.
…mpts. Optional enrichment keys belong in the Dashboard after deploy, not sync:false in the Blueprint.
✅ Deploy Preview for web-check ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
lissy93
left a comment
There was a problem hiding this comment.
looks good, overall. But the image version is old. And can you confirm that this did actually work for you with those options? And that the link is correct
| plan: standard | ||
| region: oregon | ||
| image: | ||
| url: docker.io/lissy93/web-check:2.1.10 |
There was a problem hiding this comment.
If we put this as :latest, it should always get updates
There was a problem hiding this comment.
Yep, switched it to :latest.
| - key: CHROME_PATH | ||
| value: "/usr/bin/chromium" |
There was a problem hiding this comment.
Actually not sure that this will work, on render? But I could be wrong. Did you get it working with that path?
There was a problem hiding this comment.
Yeah it works. Same path the image already sets internally, and screenshots came through on the deploy.
|
|
||
| Click the button below, to deploy to Render 👇 | ||
|
|
||
| [](https://render.com/deploy-template/api/github/start?template_repo=web-check-render-template) |
There was a problem hiding this comment.
Is this the right link though? I'd of thought it would need to point to this repo
There was a problem hiding this comment.
Updated. Button now goes to render.com/deploy?repo=https://github.com/Lissy93/web-check so it deploys from this repo.
| - key: API_ENABLE_RATE_LIMIT | ||
| value: "true" |
There was a problem hiding this comment.
This wouldn't work on render, you won't have the right headers I don't think. Since the X-Forwarded-For header will be the render IP, not clients.
There was a problem hiding this comment.
Should be alright with TRUST_PROXY=1. That's what makes Express pick up the real client IP from X-Forwarded-For instead of Render's.
| # Optional OSINT API keys: add in Dashboard after deploy (see .env.sample). Do not | ||
| # declare them as sync:false here or Apply will prompt for every key. |
There was a problem hiding this comment.
Does render not have ability to declare them here, and have them filled in when the user clicks deploy? I only ask, since I think I've seen something similar done elsewhere.
There was a problem hiding this comment.
It can (sync: false), but then Apply asks for every key even when they're optional. Left them for the dashboard after so the deploy stays quick. Happy to add a couple of the common ones if you'd rather.
|
Pushed a couple updates: Image → :latest |
Summary
render.yamlBlueprint using the officiallissy93/web-checkimagerender-examples/web-check-render-templateCloses #318
Notes
sync: falsein the Blueprint, so Apply does not prompt for them. They can be set in the dashboard after deploy if needed.Test plan
/