Skip to content

Use unstable sort for by-address symbol index creation #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
d-e-s-o wants to merge 1 commit into from
Closed

Use unstable sort for by-address symbol index creation #1544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/elf/parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ impl<'elf> SymbolTableCache<'elf> {

// Order symbols by address and those with equal address descending by
// size.
let () = by_addr_idx.sort_by(|idx1, idx2| {
let () = by_addr_idx.sort_unstable_by(|idx1, idx2| {
// SANITY: Both indexes originate in our code and are known
// to be in bounds.
let sym1 = self.syms.get(*idx1).unwrap();
Expand Down Expand Up @@ -431,7 +431,7 @@ impl<'elf> SymbolTableCache<'elf> {
})
.collect::<Result<Box<[_]>>>()?;

let () = str2sym.sort_by_key(|(name, _i)| name.bytes(&self.strs));
let () = str2sym.sort_unstable_by_key(|(name, _i)| name.bytes(&self.strs));
Ok(str2sym)
}

Expand Down
Loading