Use unstable sort for by-address symbol index creation#1544
Closed
d-e-s-o wants to merge 1 commit intolibbpf:mainfrom
Closed
Use unstable sort for by-address symbol index creation#1544d-e-s-o wants to merge 1 commit intolibbpf:mainfrom
d-e-s-o wants to merge 1 commit intolibbpf:mainfrom
Conversation
Switch create_by_addr_idx() from sort_by() to sort_unstable_by(). The stable sort allocates a temporary buffer equal in size to the input for its merge phase. The unstable variant sorts in-place instead. Stability is not required here because the secondary sort key (size descending) already fully determines the order among equal-address symbols. Apply the same change to create_str2sym()'s sort_by_key() call. Signed-off-by: Daniel Müller <deso@posteo.net>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1544 +/- ##
==========================================
- Coverage 95.51% 95.47% -0.04%
==========================================
Files 56 56
Lines 9534 9534
==========================================
- Hits 9106 9103 -3
- Misses 428 431 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Will combine this with another change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch create_by_addr_idx() from sort_by() to sort_unstable_by(). The stable sort allocates a temporary buffer equal in size to the input for its merge phase. The unstable variant sorts in-place instead. Stability is not required here because the secondary sort key (size descending) already fully determines the order among equal-address symbols.
Apply the same change to create_str2sym()'s sort_by_key() call.