Add client config flag to explicitly signal Opus support#61
Open
s3lph wants to merge 1 commit intolayeh:masterfrom
Open
Add client config flag to explicitly signal Opus support#61s3lph wants to merge 1 commit intolayeh:masterfrom
s3lph wants to merge 1 commit intolayeh:masterfrom
Conversation
…e Opus audio codec is not loaded.
This was referenced Mar 15, 2022
|
how about a dummy opus codec that registers itself but doesn't process the audio? |
Author
|
That is actually what I proposed initially as a solution for matterbridge (the project we want this for, see 42wim/matterbridge#1750 for the discussion), but @42wim (matterbridge maintainer) and I agree that we find the dummy codec solution to be a rather ugly workaround for something that's a simple boolean flag. We do have a working dummy codec implementation (42wim/matterbridge#1764), but would like to avoid using it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add client config flag to explicitly signal Opus support even when the Opus audio codec is not loaded.
This is useful if a client based on gumble doesn't actually process audio at all. By signalling Opus support anyway, this doesn't force everyone back to CELT if a gumble client is the only client not claiming Opus support. We can't be sure that the server admin has actually set
opusthreshold = 0, so this is a pure-client way to prevent a CELT fallback.