Skip to content

Mumble: Implement a workaround to signal Opus support#1764

Merged
42wim merged 3 commits into42wim:masterfrom
s3lph:mumble-opus-workaround
Mar 19, 2022
Merged

Mumble: Implement a workaround to signal Opus support#1764
42wim merged 3 commits into42wim:masterfrom
s3lph:mumble-opus-workaround

Conversation

@s3lph
Copy link
Copy Markdown
Contributor

@s3lph s3lph commented Mar 15, 2022

Workaround for #1750, in case layeh/gumble#61 isn't merged soonish™.

Comment thread bridge/mumble/codec.go Outdated
Comment thread bridge/mumble/codec.go Outdated
@42wim
Copy link
Copy Markdown
Owner

42wim commented Mar 19, 2022

@s3lph I'm planning to release a 1.24.1 soon, this PR can be merged and we can remove it later again if upstream agrees to add your PR

@s3lph s3lph force-pushed the mumble-opus-workaround branch from c968cb8 to 8f083f9 Compare March 19, 2022 16:23
@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit 8f083f9 and detected 0 issues on this pull request.

View more on Code Climate.

@s3lph s3lph marked this pull request as ready for review March 19, 2022 16:24
@42wim 42wim added the mumble label Mar 19, 2022
@42wim 42wim added this to the 1.24.1 milestone Mar 19, 2022
@42wim 42wim merged commit 663850a into 42wim:master Mar 19, 2022
@42wim
Copy link
Copy Markdown
Owner

42wim commented Mar 19, 2022

Thanks!

selfhoster1312 pushed a commit to selfhoster1312/matterbridge that referenced this pull request Oct 10, 2025
* Mumble: Implement a workaround to signal Opus support without pulling in the CGO gopus dependency.

* mumble: lowercase error messages

* mumble: Add link to 42wim#1750 in bridge/mumble/codec.go
weskerty pushed a commit to weskerty/AcopleBot that referenced this pull request Nov 30, 2025
* Mumble: Implement a workaround to signal Opus support without pulling in the CGO gopus dependency.

* mumble: lowercase error messages

* mumble: Add link to 42wim#1750 in bridge/mumble/codec.go
wbonis pushed a commit to styliteag/matterbridge that referenced this pull request Feb 9, 2026
* Mumble: Implement a workaround to signal Opus support without pulling in the CGO gopus dependency.

* mumble: lowercase error messages

* mumble: Add link to 42wim#1750 in bridge/mumble/codec.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants