Skip to content

fix(mysql-8.4): As of mysql 8.4, expire_logs_days is removed in favour of binlog_expire_logs_seconds. - #108

Merged
AaronFeledy merged 2 commits into
lando:mainfrom
florianPat:fix/mysql_84_config
Oct 15, 2026
Merged

AaronFeledy merged 2 commits into
lando:mainfrom
florianPat:fix/mysql_84_config

Conversation

@florianPat

@florianPat florianPat commented Jun 28, 2026 •

Copy link
Copy Markdown

The default is 30 days, so I just removed it so the database starts again on version 8.4 and we do not need another config just for this option

Bare minimum self-checks

What do you think of a person who only does the bare minimum?

Pieces of flare

  • I've written a unit or functional test for my code
  • I've updated relevant documentation it my code changes it
  • I've updated this repo's README if my code changes it
  • I've updated this repo's CHANGELOG with my change unless its a trivial change (like updating a typo in the docs)

Finally

If you have any issues or need help please join the #contributors channel in the Lando slack and someone will gladly help you out!

You can also check out the coder guide.

@netlify

netlify Bot commented Jun 28, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for lando-lamp ready!

Name Link
🔨 Latest commit 6140089
🔍 Latest deploy log https://app.netlify.com/projects/lando-lamp/deploys/6ad103bfa318f584b4e2d0f2
😎 Deploy Preview https://deploy-preview-108--lando-lamp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 84 (🔴 down 2 from production)
Accessibility: 96 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

florianPat and others added 2 commits October 15, 2026 11:47
…r of binlog_expire_logs_seconds. The default is 30 days, so I just removed it so the database starts again on version 8.4 and we do not need another config just for this option
@AaronFeledy

Copy link
Copy Markdown
Member

Rebased onto main and added one commit on top of this fix. It keeps the 10 day binlog retention with binlog_expire_logs_seconds = 864000 rather than falling back to the 30 day default, routes the bare mysql:8 alias to the MySQL 8 config, and adds a changelog entry and a lamp-mysql84 CI example. I'll rebase-merge this so your commit stays in the history. Thanks for the fix, @florianPat!

@AaronFeledy
AaronFeledy merged commit a30a9a7 into lando:main Oct 15, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants